[GitHub] dgrove-oss commented on a change in pull request #3156: move PureConfig strings to PureConfigKeys singleton

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #3156: move PureConfig strings to PureConfigKeys singleton
URL: https://github.com/apache/incubator-openwhisk/pull/3156#discussion_r160194329
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/WhiskConfig.scala
 ##########
 @@ -244,4 +244,7 @@ object PureConfigKeys {
   val whiskKafkaTopics = "whisk.kafka.topics"
 
   val whiskDB = "whisk.db"
+
+  val whiskDockerTimeouts = "whisk.docker.timeouts"
+  val whiskRuncTimeouts = "whisk.runc.timeouts"
 
 Review comment:
   Makes sense to me.  I'll do a follow up PR to drop Pure and apply the s"$" cascading in your comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services