You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/06 07:00:34 UTC
[GitHub] [spark] huangtianhua opened a new pull request #30275: SPARK-32691 Bump commons-crypto to v1.1.0
huangtianhua opened a new pull request #30275:
URL: https://github.com/apache/spark/pull/30275
The package commons-crypto-1.0.0 doesn't support aarch64 platform, it lead
the tests of replication failed due to crypto timeout, bump up to v1.1.0 which
support aarch64.
See:
https://issues.apache.org/jira/browse/CRYPTO-139
http://commons.apache.org/proper/commons-crypto/changes-report.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723758856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723758086
**[Test build #130761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130761/testReport)** for PR 30275 at commit [`f85835b`](https://github.com/apache/spark/commit/f85835bee05c301ddf336dced2eeadf1fa236c20).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723738417
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangtianhua commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
huangtianhua commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723821241
@dongjoon-hyun, thanks and I will add more logic details in the PR description.
Please add a new and independent test case which is applicable for master and branch-3.0 for SPARK-32691. --- I think the caching tests in DistributedSuite.scala is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723738410
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722915891
Thank you for your contribution, @huangtianhua . Could you recover the original PR description style please? Please see a PR like https://github.com/apache/spark/pull/30274 as an example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30275:
URL: https://github.com/apache/spark/pull/30275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723758856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-724317521
@huangtianhua . I'll merge this to `master` branch for Apache Spark 3.1.0.
If you need a backport to `branch-3.0` for Apache Spark 3.0.x, please make a backporting PR with the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723721403
**[Test build #130761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130761/testReport)** for PR 30275 at commit [`f85835b`](https://github.com/apache/spark/commit/f85835bee05c301ddf336dced2eeadf1fa236c20).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917000
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723721403
**[Test build #130761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130761/testReport)** for PR 30275 at commit [`f85835b`](https://github.com/apache/spark/commit/f85835bee05c301ddf336dced2eeadf1fa236c20).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723731910
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722915891
Thank you for your contribution, @huangtianhua . Could you recover the original PR description style please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-724317521
@huangtianhua . I'll merge this to `master` branch for Apache Spark 3.1.0 for https://issues.apache.org/jira/browse/CRYPTO-139.
If you need a backport to `branch-3.0` for Apache Spark 3.0.x, please make a backporting PR with the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723738421
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35370/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723738417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917362
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917000
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723542935
Why change the PR description style from
```
### Why are the changes needed?
```
to
```
**What changes were proposed in this pull request?**
```
?
Please just copy the original PR description template and fill the sections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-723719799
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-724135135
Thank you for updating the PR description, @huangtianhua .
For the following, do you mean `the caching tests` fail in `branch-3.0` currently? For the unit test, we need a unit test which fails without this patch.
> I think the caching tests in DistributedSuite.scala is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30275: [SPARK-32691][BUILD] Update commons-crypto to v1.1.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917362
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org