You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2018/10/01 16:46:20 UTC

[GitHub] DavidMcLaughlin commented on a change in pull request #41: Memoize loader.load and loader.load_json

DavidMcLaughlin commented on a change in pull request #41: Memoize loader.load and loader.load_json
URL: https://github.com/apache/aurora/pull/41#discussion_r221678780
 
 

 ##########
 File path: src/test/python/apache/aurora/config/test_loader.py
 ##########
 @@ -93,6 +101,27 @@ def test_load_json_single():
   assert new_job == job
 
 
+def test_load_json_memoized():
 
 Review comment:
   Is this actually testing memoization? Shouldn't it be asserting that the pystachio evaluation/loading isn't done on the second request? I think this test would pass if you pass in is_memoized=False as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services