You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/24 03:17:58 UTC
[jira] [Commented] (S2GRAPH-130) Edge.propsWithTs data type should
be changed into mutable to support setter interface exist in tp3.
[ https://issues.apache.org/jira/browse/S2GRAPH-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692048#comment-15692048 ]
ASF GitHub Bot commented on S2GRAPH-130:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/100
[S2GRAPH-130]: Edge.propsWithTs data type should be changed into mutable to support setter interface exist in tp3.
- Change data type of Edge.propsWithTs to java.util.Map.
- Make Vertex/Edge/Graph to implement Tinkerpop3 structure interface.
Note that this PR based on #99 PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 292174ecf8da32604d61cb5f8388b8d9eeb54be3
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-24T01:46:27Z
[S2GRAPH-129]: Restrict direct access on Edge's properties from other classes.
- add tp3 as dependencies.
- make propsWithTs as private.
commit 6356573e6a658dbfeb240bdee642d055991e5ac2
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-24T03:14:08Z
[S2GRAPH-130]: Edge.propsWithTs data type should be changed into mutable to support setter interface exist in tp3.
- Make Vertex/Edge/Graph to implement Tinkerpop3.
- Change data type of Edge's propsWithTs to java.util.Map[String, S2Property[_]].
----
> Edge.propsWithTs data type should be changed into mutable to support setter interface exist in tp3.
> ---------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-130
> URL: https://issues.apache.org/jira/browse/S2GRAPH-130
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
>
> Change {{Edge.propsWithTs}} data type to java.util.Map[should be changed into mutable to support setter interface exist in tp3.
> This issue intentionally left implementation for interface in tp3, but rather focus changing S2Graph's core {{Edge/Vertex/Graph}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)