(spark) branch branch-4.x updated: [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results

[ur...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

uros-b pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.x by this push:
     new 607fcce250d2 [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results
607fcce250d2 is described below

commit 607fcce250d2d604ec437a19a91fb36630fac0aa
Author: Uros Bojanic <22...@users.noreply.github.com>
AuthorDate: Tue Aug 4 15:19:55 2026 +0000

    [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results
    
    ### What changes were proposed in this pull request?
    Uses the named `containsNull = false` argument in the two `dataType` overrides of the KLL sketch expressions, matching the named form already used by the `inputTypes` declarations in the same classes.
    
    ### Why are the changes needed?
    `ArrayType`'s second (and final) parameter is `containsNull`, so bare positional `false` and `containsNull = false` compile identically; this only aligns the two outliers with the file's own dominant idiom.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Stylistic, behavior-identical change. No new tests needed.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    Generated-by: Claude Code (Opus 4.8)
    
    Closes #57642 from uros-b/consistency-kll-containsnull-named.
    
    Authored-by: Uros Bojanic <22...@users.noreply.github.com>
    Signed-off-by: Uros Bojanic <22...@users.noreply.github.com>
    (cherry picked from commit 496d20f8c05fa93407edefb123134026e259b9fe)
    Signed-off-by: Uros Bojanic <22...@users.noreply.github.com>
---
 .../org/apache/spark/sql/catalyst/expressions/kllExpressions.scala    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
index ba6c68ab95fc..218146155837 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala
@@ -564,7 +564,7 @@ abstract class KllSketchGetQuantileBase
 
   override def dataType: DataType = {
     right.dataType match {
-      case ArrayType(_, _) => ArrayType(outputDataType, false)
+      case ArrayType(_, _) => ArrayType(outputDataType, containsNull = false)
       case _ => outputDataType
     }
   }
@@ -750,7 +750,7 @@ abstract class KllSketchGetRankBase
   }
   override def dataType: DataType = {
     right.dataType match {
-      case ArrayType(_, _) => ArrayType(DoubleType, false)
+      case ArrayType(_, _) => ArrayType(DoubleType, containsNull = false)
       case _ => DoubleType
     }
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org