You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/24 22:30:41 UTC

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5181: Nightly deploy pinot to bintray

jackjlli opened a new pull request #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181
 
 
   This PR adds code to nightly deploy pinot to bintray.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5181: Nightly deploy pinot to bintray

Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181#discussion_r398246256
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -1,57 +1,25 @@
 language: java
 sudo: false
 dist: trusty
-
 before_install:
-  - mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 && chmod +x ~/bin/jq
-  - export PATH=$PATH:~/bin
-  - jq --version
-
+- mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64
+  && chmod +x ~/bin/jq
+- export PATH=$PATH:~/bin
+- jq --version
+- export DEV_VERSION="-dev-${TRAVIS_BUILD_NUMBER}"
 jdk:
-  - oraclejdk8
-
+- oraclejdk8
 cache:
   directories:
-    - $HOME/.m2
+  - "$HOME/.m2"
   yarn: true
-
 addons:
   firefox: latest
-
 install:
-  - ./.travis_install.sh
-
-branches:
-  only:
-    - master
-
-jobs:
-  include:
-    - name: "Integration Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=true
-    - name: "Unit Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=false
-    - name: "QuickStart - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OracleJDK 11"
-      jdk: oraclejdk11
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 8"
-      jdk: openjdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 11"
-      jdk: openjdk11
-      script:
-        - ./.travis_quickstart.sh
+- "./.travis_install.sh"
+script:
+- "./.travis_nightly_build.sh"
+env:
+  global:
+  - secure: R3NdobUAThkk6BBzXapek6PiuWHWa1ldnJBvXpk2TAi7Lua/Ctgg8EHCSve7+MK4SU3XFJSi1th32+VSy0K/ARfdVcxiVh6EJSL/Nw0LRQSvGk7VjO382SsWCFoJuZBBqjy9DfBgRLdoqEPfulIBC0XBxjJ+4xedRptkZo7+TAAvtB8Y32EA5ve+Z4cdJipLF1tviL5q2rVbkNXucYUYO2XIv5HOzF2Xy3Hw6lsNrHpbes2CLEkoMiLOQ30zfbXZT/5Xd6OhQNmoZJ9gKziT1opiN2AJMPv269K8FFJZTrDZX74/thq9wmeF4X4f3wPA7EbTupooj0i9LPzb8Xev1QKAsxBtHyRm9NGYOXM06c2yKiGsDtT4HZYQGk4m8/89moe3oGnEwvw/JLu5RvLIZzFE2cBhHrcxRAJgHLIr80+kebNg/YstNlDL+rmP0b9NRrGIVw5OO2BT27ZBgsMFmjnujQtCUJiJ5zqyMxygaYmgZha6xcbhFUPyf4DJ3T46etyFovg2EJnhM7HL9ECZHloQZFhEKs88sZXqvt6HKsA77xyL7ONMrwcPtdDVbFUkN/B1R7LLOf6Wq5vK/Y2EB18oXhKF0ngdahT8HKSMTXjuYf5MPybxhf4fdY6stFmIVkd9b633iZDMu+Aj8E1c8BApyDikCmYK2BI3grH49E0=
 
 Review comment:
   No, no need to do so. 
   ```
   Please note that encrypted environment variables are not available for pull requests from forks.
   ```
   First, someone else cannot create a branch from this repo. 
   Second, this release deployment will be set up to be triggered only when the build is a cron job.
   Third, this release deployment will be set up to be triggered only when the build isn't from PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5181: Nightly deploy pinot to bintray

Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181#discussion_r398246256
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -1,57 +1,25 @@
 language: java
 sudo: false
 dist: trusty
-
 before_install:
-  - mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 && chmod +x ~/bin/jq
-  - export PATH=$PATH:~/bin
-  - jq --version
-
+- mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64
+  && chmod +x ~/bin/jq
+- export PATH=$PATH:~/bin
+- jq --version
+- export DEV_VERSION="-dev-${TRAVIS_BUILD_NUMBER}"
 jdk:
-  - oraclejdk8
-
+- oraclejdk8
 cache:
   directories:
-    - $HOME/.m2
+  - "$HOME/.m2"
   yarn: true
-
 addons:
   firefox: latest
-
 install:
-  - ./.travis_install.sh
-
-branches:
-  only:
-    - master
-
-jobs:
-  include:
-    - name: "Integration Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=true
-    - name: "Unit Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=false
-    - name: "QuickStart - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OracleJDK 11"
-      jdk: oraclejdk11
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 8"
-      jdk: openjdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 11"
-      jdk: openjdk11
-      script:
-        - ./.travis_quickstart.sh
+- "./.travis_install.sh"
+script:
+- "./.travis_nightly_build.sh"
+env:
+  global:
+  - secure: R3NdobUAThkk6BBzXapek6PiuWHWa1ldnJBvXpk2TAi7Lua/Ctgg8EHCSve7+MK4SU3XFJSi1th32+VSy0K/ARfdVcxiVh6EJSL/Nw0LRQSvGk7VjO382SsWCFoJuZBBqjy9DfBgRLdoqEPfulIBC0XBxjJ+4xedRptkZo7+TAAvtB8Y32EA5ve+Z4cdJipLF1tviL5q2rVbkNXucYUYO2XIv5HOzF2Xy3Hw6lsNrHpbes2CLEkoMiLOQ30zfbXZT/5Xd6OhQNmoZJ9gKziT1opiN2AJMPv269K8FFJZTrDZX74/thq9wmeF4X4f3wPA7EbTupooj0i9LPzb8Xev1QKAsxBtHyRm9NGYOXM06c2yKiGsDtT4HZYQGk4m8/89moe3oGnEwvw/JLu5RvLIZzFE2cBhHrcxRAJgHLIr80+kebNg/YstNlDL+rmP0b9NRrGIVw5OO2BT27ZBgsMFmjnujQtCUJiJ5zqyMxygaYmgZha6xcbhFUPyf4DJ3T46etyFovg2EJnhM7HL9ECZHloQZFhEKs88sZXqvt6HKsA77xyL7ONMrwcPtdDVbFUkN/B1R7LLOf6Wq5vK/Y2EB18oXhKF0ngdahT8HKSMTXjuYf5MPybxhf4fdY6stFmIVkd9b633iZDMu+Aj8E1c8BApyDikCmYK2BI3grH49E0=
 
 Review comment:
   No, no need to do so. 
   ```
   Please note that encrypted environment variables are not available for pull requests from forks.
   ```
   First, someone else cannot create a branch from this repo. 
   Second, this release deployment will be set up to be triggered only when the build is a cron job.
   Third, this release deployment will be set up to be triggered only when the build isn't from PR.
   Fourth, they are encrypted. They cannot be used locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] jackjlli commented on issue #5181: Nightly deploy pinot to bintray

Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181#issuecomment-605133758
 
 
   Closing this PR since the .m2 cache in this PR becomes too large and Travis couldn't load it in 10 mins.
   The new finalized PR is in https://github.com/apache/incubator-pinot/pull/5190.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] jackjlli closed pull request #5181: Nightly deploy pinot to bintray

Posted by GitBox <gi...@apache.org>.
jackjlli closed pull request #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] snleee commented on a change in pull request #5181: Nightly deploy pinot to bintray

Posted by GitBox <gi...@apache.org>.
snleee commented on a change in pull request #5181: Nightly deploy pinot to bintray
URL: https://github.com/apache/incubator-pinot/pull/5181#discussion_r398242443
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -1,57 +1,25 @@
 language: java
 sudo: false
 dist: trusty
-
 before_install:
-  - mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 && chmod +x ~/bin/jq
-  - export PATH=$PATH:~/bin
-  - jq --version
-
+- mkdir -p ~/bin && curl -sSL -o ~/bin/jq https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64
+  && chmod +x ~/bin/jq
+- export PATH=$PATH:~/bin
+- jq --version
+- export DEV_VERSION="-dev-${TRAVIS_BUILD_NUMBER}"
 jdk:
-  - oraclejdk8
-
+- oraclejdk8
 cache:
   directories:
-    - $HOME/.m2
+  - "$HOME/.m2"
   yarn: true
-
 addons:
   firefox: latest
-
 install:
-  - ./.travis_install.sh
-
-branches:
-  only:
-    - master
-
-jobs:
-  include:
-    - name: "Integration Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=true
-    - name: "Unit Tests - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_test.sh
-      env:
-        - RUN_INTEGRATION_TESTS=false
-    - name: "QuickStart - OracleJDK 8"
-      jdk: oraclejdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OracleJDK 11"
-      jdk: oraclejdk11
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 8"
-      jdk: openjdk8
-      script:
-        - ./.travis_quickstart.sh
-    - name: "QuickStart - OpenJDK 11"
-      jdk: openjdk11
-      script:
-        - ./.travis_quickstart.sh
+- "./.travis_install.sh"
+script:
+- "./.travis_nightly_build.sh"
+env:
+  global:
+  - secure: R3NdobUAThkk6BBzXapek6PiuWHWa1ldnJBvXpk2TAi7Lua/Ctgg8EHCSve7+MK4SU3XFJSi1th32+VSy0K/ARfdVcxiVh6EJSL/Nw0LRQSvGk7VjO382SsWCFoJuZBBqjy9DfBgRLdoqEPfulIBC0XBxjJ+4xedRptkZo7+TAAvtB8Y32EA5ve+Z4cdJipLF1tviL5q2rVbkNXucYUYO2XIv5HOzF2Xy3Hw6lsNrHpbes2CLEkoMiLOQ30zfbXZT/5Xd6OhQNmoZJ9gKziT1opiN2AJMPv269K8FFJZTrDZX74/thq9wmeF4X4f3wPA7EbTupooj0i9LPzb8Xev1QKAsxBtHyRm9NGYOXM06c2yKiGsDtT4HZYQGk4m8/89moe3oGnEwvw/JLu5RvLIZzFE2cBhHrcxRAJgHLIr80+kebNg/YstNlDL+rmP0b9NRrGIVw5OO2BT27ZBgsMFmjnujQtCUJiJ5zqyMxygaYmgZha6xcbhFUPyf4DJ3T46etyFovg2EJnhM7HL9ECZHloQZFhEKs88sZXqvt6HKsA77xyL7ONMrwcPtdDVbFUkN/B1R7LLOf6Wq5vK/Y2EB18oXhKF0ngdahT8HKSMTXjuYf5MPybxhf4fdY6stFmIVkd9b633iZDMu+Aj8E1c8BApyDikCmYK2BI3grH49E0=
 
 Review comment:
   Is there a way to hide this? What the standard practice on putting key? 
   
   For instance, can someone copy this key and make some random release to our repo?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org