You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2018/12/01 04:29:04 UTC

[GitHub] spark pull request #23192: [SPARK-26221][SQL] Add queryId to IncrementalExec...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/23192

    [SPARK-26221][SQL] Add queryId to IncrementalExecution

    ## What changes were proposed in this pull request?
    This is a small change for better debugging: to pass query uuid in IncrementalExecution, when we look at the QueryExecution in isolation to trace back the query.
    
    ## How was this patch tested?
    N/A - just add some field for better debugging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-26241

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23192
    
----
commit c037f4d2fa2c2844ac992d976b492e14ab9bed11
Author: Reynold Xin <rx...@...>
Date:   2018-12-01T04:27:00Z

    [SPARK-26221]

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5599/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    cc @zsxwing @jose-torres 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    **[Test build #99536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99536/testReport)** for PR 23192 at commit [`c037f4d`](https://github.com/apache/spark/commit/c037f4d2fa2c2844ac992d976b492e14ab9bed11).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99536/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26241][SQL] Add queryId to IncrementalExecution

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Thanks @HyukjinKwon. Fixed it.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #23192: [SPARK-26241][SQL] Add queryId to IncrementalExec...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/23192


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    **[Test build #99536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99536/testReport)** for PR 23192 at commit [`c037f4d`](https://github.com/apache/spark/commit/c037f4d2fa2c2844ac992d976b492e14ab9bed11).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Hey Reynold looks JIRA had to be `SPARK-26241`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #23192: [SPARK-26221][SQL] Add queryId to IncrementalExecution

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23192
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org