[GitHub] [incubator-mxnet] josephevans edited a comment on pull request #18752: Fix linalg_potri and linalg_potrf operators for large tensor.

[GitBox <gi...@apache.org>]

josephevans edited a comment on pull request #18752:
URL: https://github.com/apache/incubator-mxnet/pull/18752#issuecomment-663618670


   > Can you add the results by running
   > 
   > ```
   > pytest tests/nightly/test_large_array.py::<insert function_name>
   > ```
   > 
   
   Test results are already in the description. :)
   
   > Also you could rework the tests so that you add backward & forward in the same call
   > Similar to @mseth10 #18744
   > 
   > Something like
   > 
   > ```
   > def run_<op>(inp):
   >         inp.attach_grad()
   >         with mx.autograd.record():
   >             out = mx.nd.linalg.<op>(inp)
   >         return inp.grad, out
   > ```
   
   I will follow up with an additional PR to add backward tests for these two operators.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org