You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/25 08:22:28 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new issue, #2321: Trackings issues of the first release of OpenDAL C binding
Xuanwo opened a new issue, #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321
OpenDAL C binding is get started but there are some tasks we need to address for our first release.
## Tasks
- [ ] Implement operator builder
- [ ] Implement all behavior tests
- [ ] Workflows for linux/windows/macos release
- [ ] Maybe deb/rpm for ubuntu/centos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1563970544
> I think several examples for typical use cases are needed for the release, since we do not have any official documentation for C binding yet.
Seems C doesn't have docs genenator like `rustdoc`, we can add them in `website` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566238624
> If doxygen is too complicated to use, we can write API docs in website directly.
I will try doxygen first. If that's not working, we write docs in the website directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1635493464
@jiaoew1991 See #2448 , just wait this to be merged ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565534232
Hi, @Ji-Xinyou, I have updated our tasks list, please take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285524436
> Now we have testings and examples for opendal C bindings, i would like to achieve this release since i have some bandwidth now.
In fact, we have released C multiple times as a tarball, such as https://dlcdn.apache.org/opendal/0.48.0/. I believe we can continue to release it this way.
Additionally, does the user want `libopendal_c.so` or something similar?
> For releasing, since the bindings functionality grows with the core, the semver thing still need some discussion. I am thinking for each update release in core, we release C with a PATCH version; for each important feature implementation, we release with a MINOR; for each breaking change, we release with a MAJOR.
The current release strategy for the entire OpenDAL project is as follows:
- No breaking changes: PATCH.
- Breaking changes: MINOR.
We will introduce MAJOR updates once our core reaches version `1.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "xyjixyjixyji (via GitHub)" <gi...@apache.org>.
xyjixyjixyji commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285935457
IC, i am mentioning this cuz we don't have an official release on the homepage README 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1575960316
> What abt this. We setup a most common `read + write` example in both `./bindings/c/examples` and the website. And put other examples in `./bindings/c/examples` only and mention that in the website documentation.
LGTM, let's get work started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [incubator-opendal]
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1778482553
> > I think we should start considering the release for C binding.
>
>
>
> We're on track to graduate from ASF Incubator. How about we start this project after graduation?
I think so. That's 100% with higher priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566190815
> But you still need to provide a way to view it online. I think it's better to provide the documentation with the familiar look of the C ecosystem.
Then we should use `doxygen` then. I will look into this on how to better integrate the Rust comments with doxygen-style comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "xyjixyjixyji (via GitHub)" <gi...@apache.org>.
xyjixyjixyji commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285895496
SG, then we keep releasing so in this way should be good. We could implement an async support, make the doc more compelete and then we are go to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [incubator-opendal]
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1778431082
I think we should start considering the release for C binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] jiaoew1991 commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "jiaoew1991 (via GitHub)" <gi...@apache.org>.
jiaoew1991 commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1576636544
Request an "opendal_operator_blocking_list" interface in C binding 😄.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1575629104
I would like some opinions. As for the example part, which of the following do we need.
- An example with classical usage on many APIs, such as `stat`, `is_exist`, `read` and `write`
- A small example with only `read` and `write`, and multiple others showing some other APIs
I personally prefer the second one since the API will grows and putting them altogether is not a good practice IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1778491532
> I think so. That's 100% with higher priority.
Thanks! I'm guessing we can add test framework first to make sure C binding works on all our services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285958236
> IC, i am mentioning this cuz we don't have an official release on the homepage README 😉 But i guess we don't need an **Official** release then
Yes, we don't need that. We can point to the correct place of our `tar` and let user know how to build them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1562495939
> Hey @Ji-Xinyou, we previously worked on implementing a code generator for the operator builder. However, I realized that it's not a good idea. It would be more beneficial for us to begin with `Operator::via_map` instead.
>
> Do you still interested in implement `operator_new` with a map in c binding?
Yes, I do. A map way is certainly acceptable, but I think a builder based way is also needed. What do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1581643690
> I will work on that ASAP
Let's track this in a new issue instead. I believe it not a block of our first release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565241044
> As for the behavior tests, what tests are expected. So far I understand this as implement all behavior tests in Rust core for the C binding (such as write_test etc.). Please notify me if there is any misunderstanding.
Please refer to `bindings/test` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1563952370
I think several examples are needed for the release, since we do not have any official documentation for C binding yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1563979740
> The doxygen would be a way to generate docs, we could use that.
I'm a bit afraid of the complexity of `doxygen`, but it's still okay to use. Thanks for remind!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566204803
If doxygen is too complicated to use, we can write API docs in website directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285910766
> We could implement an async support, make the doc more compelete and then we are good to go?
We will maintain the current release workflow, ensuring that tasks do not block each other. This allows us to continue adding new features, such as async support and additional docs, simultaneously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285582613
> One concern is that releasing through deb/rpm seems like not the way that Apache releases work, so does that mean we release the `so` in the release should be fine?
Binary releases like deb/rpm are not part of the Apache release; we provide them solely for user convenience.
Generally, we do not include `.so` files in the release. Instead, we need to build and upload them to https://apache.jfrog.io/, similar to how Arrow does it: https://arrow.apache.org/install/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1562498454
> but I think a builder based way is also needed
I agree with this too. However, since we've spent a significant amount of time on it already, perhaps we can begin by offering users a functional C binding first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] jiaoew1991 commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "jiaoew1991 (via GitHub)" <gi...@apache.org>.
jiaoew1991 commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1633495693
> > Request an "opendal_operator_blocking_list" interface in C binding 😄.
>
> I will work on that ASAP 😆
Hi @Ji-Xinyou How's this going? 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565251181
I think we should align with our features. For example:
https://github.com/apache/incubator-opendal/blob/8797a2424bdc294e6936e49c52e5f31abd4ed002/bindings/c/tests/bdd.cpp#L68-L69
We should not call `opendal_operator_blocking_write` in `SetUp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566190158
But you still need to provide a way to view it online. I think it's better to provide the documentation with the familiar look of the C ecosystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1575645079
> We can also share the markdown files between website and code too if needed. But for simple, we can start by in website first.
What abt this. We setup a most common `read + write` example in both `./bindings/c/examples` and the website. And put other examples in `./bindings/c/examples` only and mention that in the website documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1575629795
> * A small example with only `read` and `write`, and multiple others showing some other APIs
LGTM! Most users will use OpenDAL for specific purposes, such as reading data from a remote location, writing data to a remote location, or listing files. We can provide examples for them. Maybe in website docs directly like `services`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1575949077
> Maybe in website docs directly like `services`?
We can introduce our public API and give examples like API reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1579808445
> Request an "opendal_operator_blocking_list" interface in C binding 😄.
I will work on that ASAP 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] jiaoew1991 commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "jiaoew1991 (via GitHub)" <gi...@apache.org>.
jiaoew1991 commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1562575940
Looking forward to the improvement of c binding ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565238662
As for the behavior tests, what tests are expected. So far I understand this as implement all behavior tests in Rust core for the C binding (such as write_test etc.). Please notify me if there is any misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565241341
> Please refer to `bindings/test` for now.
That has already been implemented in `bindings/c/tests/bdd.cpp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1567432623
Great news, the doxygen is working well IMO 😆
One concern when rewriting the doc, how does user know the suitable key-value pairs to passed into the `opendal_operator_new`. It seems that the users currently have to look it up rather in the `from_map` implementation for each `Backend` or in [here](https://opendal.apache.org/docs/rust/opendal/services/index.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566187602
Just a idea. What about we inline the documentation in the comment doc of our C binding code. User can directly use `cargo doc` to see the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "xyjixyjixyji (via GitHub)" <gi...@apache.org>.
xyjixyjixyji closed issue #2321: Trackings issues of the first release of OpenDAL C binding
URL: https://github.com/apache/opendal/issues/2321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1778480972
> I think we should start considering the release for C binding.
We're on track to graduate from ASF Incubator. How about we start this project after graduation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "xyjixyjixyji (via GitHub)" <gi...@apache.org>.
xyjixyjixyji commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285341310
Now we have testings and examples for opendal C bindings, i would like to achieve this release since i have some bandwidth now.
Except for releasing, what features and requirements do we need for the first release?
For releasing, since the bindings functionality grows with the core, the semver thing still need some discussion. I am thinking for each update release in core, we release C with a PATCH version; for each important feature implementation, we release with a MINOR; for each breaking change, we release with a MAJOR.
\cc @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Trackings issues of the first release of OpenDAL C binding [opendal]
Posted by "xyjixyjixyji (via GitHub)" <gi...@apache.org>.
xyjixyjixyji commented on issue #2321:
URL: https://github.com/apache/opendal/issues/2321#issuecomment-2285541630
I think we still need to release it as deb/rpm packages for user to install it easily when they build in a container, which is often the use case.
The release strategy SGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1633496896
> > > Request an "opendal_operator_blocking_list" interface in C binding 😄.
>
> >
>
> > I will work on that ASAP 😆
>
>
>
> Hi @Ji-Xinyou How's this going? 😊
I expect this to be done today or tomorrow. Sorry for being late. I have been really busy recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1565303483
> I think we should align with our features. For example:
>
> https://github.com/apache/incubator-opendal/blob/8797a2424bdc294e6936e49c52e5f31abd4ed002/bindings/c/tests/bdd.cpp#L68-L69
>
> We should not call `opendal_operator_blocking_write` in `SetUp`.
>
> Others LGTM, we can start working on some examples and prepare for release.
I will modify it to align with the bdd feature. I did that because all the tests need a write before hand lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1566204173
> Just a idea. What about we inline the documentation in the comment doc of our C binding code. User can directly use `cargo doc` to see the documentation.
I don't like this idea. Every binding should use their own way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ji-Xinyou commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1563973769
> Seems C doesn't have docs genenator like `rustdoc`, we can add them in `website` directly.
The doxygen would be a way to generate docs, we could use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2321: Trackings issues of the first release of OpenDAL C binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2321:
URL: https://github.com/apache/incubator-opendal/issues/2321#issuecomment-1562493792
Hey @Ji-Xinyou, we previously worked on implementing a code generator for the operator builder. However, I realized that it's not a good idea. It would be more beneficial for us to begin with `Operator::via_map` instead.
Do you still interested in implement `operator_new` with a map in c binding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org