[GitHub] [superset] eschutho commented on a diff in pull request #19904: feat(sip-68): Allow explore/form_data cache to accept sl_id + sl_type for downstream queries execution

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #19904:
URL: https://github.com/apache/superset/pull/19904#discussion_r865463263


##########
superset/explore/form_data/api.py:
##########
@@ -109,7 +109,9 @@ def post(self) -> Response:
             tab_id = request.args.get("tab_id")
             args = CommandParameters(
                 actor=g.user,
-                dataset_id=item["dataset_id"],
+                sl_id=item.get("sl_id"),
+                sl_type=item.get("sl_type"),
+                dataset_id=item.get("dataset_id"),

Review Comment:
   I don't think we'll need dataset_id any more. Can we just make this a more generic datasource_id and datasource_type and then remove dataset_id? Or is there something else preventing us from renaming this field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org