You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org> on 2008/10/08 17:53:44 UTC

[jira] Created: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Queue browsing runs out of credit in broker after prefetch is filled.
---------------------------------------------------------------------

                 Key: QPID-1331
                 URL: https://issues.apache.org/jira/browse/QPID-1331
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: M4
            Reporter: Aidan Skinner
             Fix For: M4


SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1331:
------------------------------------

    Assignee: Martin Ritchie

> Queue browsing runs out of credit in broker after prefetch is filled.
> ---------------------------------------------------------------------
>
>                 Key: QPID-1331
>                 URL: https://issues.apache.org/jira/browse/QPID-1331
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>         Attachments: QueueBrowser.patch
>
>
> SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1331:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Queue browsing runs out of credit in broker after prefetch is filled.
> ---------------------------------------------------------------------
>
>                 Key: QPID-1331
>                 URL: https://issues.apache.org/jira/browse/QPID-1331
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>         Attachments: QueueBrowser.patch
>
>
> SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1331:
------------------------------------

    Assignee: Aidan Skinner  (was: Martin Ritchie)

Hi Aidan, rather than using the patch I made the Browser behave the same as the NoAck Subscriber by returning false from wouldSuspend() this seemed to be more in keeping with current approach. It should also be more obvious what needs to be undone when we come to correctly implement Browsing.

Cast your eyes over the accompanying test and let me know what you think. 

> Queue browsing runs out of credit in broker after prefetch is filled.
> ---------------------------------------------------------------------
>
>                 Key: QPID-1331
>                 URL: https://issues.apache.org/jira/browse/QPID-1331
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>            Assignee: Aidan Skinner
>             Fix For: M4
>
>         Attachments: QueueBrowser.patch
>
>
> SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner resolved QPID-1331.
---------------------------------

    Resolution: Fixed

> Queue browsing runs out of credit in broker after prefetch is filled.
> ---------------------------------------------------------------------
>
>                 Key: QPID-1331
>                 URL: https://issues.apache.org/jira/browse/QPID-1331
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>            Assignee: Aidan Skinner
>             Fix For: M4
>
>         Attachments: QueueBrowser.patch
>
>
> SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1331) Queue browsing runs out of credit in broker after prefetch is filled.

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner updated QPID-1331:
--------------------------------

    Attachment: QueueBrowser.patch

Patch from ritchiem

> Queue browsing runs out of credit in broker after prefetch is filled.
> ---------------------------------------------------------------------
>
>                 Key: QPID-1331
>                 URL: https://issues.apache.org/jira/browse/QPID-1331
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>             Fix For: M4
>
>         Attachments: QueueBrowser.patch
>
>
> SubscriptionImpl runs down the clients credit when the client is browsing the queue. After it's delivered $prefetch messages it will never deliver any more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.