You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/23 18:30:34 UTC

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version to current stable (1.6) version

ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-663164146


   > while this change looks good, I think we definitely shouldn't make `.htaccess` a requirement for hosting as it precludes simple static hosting on file systems. This has been preventing a preview for website from being available in PRs and has caused many issues.
   > 
   > I think removing website preview in PRs for using `.htaccess` was a wrong decision, and if the preview can't be re-enabled, we should deprecate the usage of `.htaccess`.
   
   Thanks for reviewing. Since there are many content missing issues recently on master website reported from our customers. 
   @sandeep-krishnamurthy  We decided to submit a fix ASAP without making large changes to website file structure and build process.
   
   It would be good to reduce the usage of `.htaccess` to enable PR preview, but this need to start from fixing existing broken links since v1.6, which will take much longer time. Currently we think it is more critical to address customer complains in a short amount of time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org