Re: [PR] [GOBBLIN-2013] update guice initialization for 'DagProcEngine enabled' and related classes [gobblin]

["phet (via GitHub)" <gi...@apache.org>]

phet commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520874454


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -59,6 +69,30 @@ public final class FlowCompilationValidationHelper {
   private final FlowStatusGenerator flowStatusGenerator;
   private final boolean isFlowConcurrencyEnabled;
 
+  @Inject
+  public FlowCompilationValidationHelper(Config config, SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
+      UserQuotaManager userQuotaManager, FlowStatusGenerator flowStatusGenerator) {
+    try {
+      String specCompilerClassName = ServiceConfigKeys.DEFAULT_GOBBLIN_SERVICE_FLOWCOMPILER_CLASS;
+      if (config.hasPath(ServiceConfigKeys.GOBBLIN_SERVICE_FLOWCOMPILER_CLASS_KEY)) {
+        specCompilerClassName = config.getString(ServiceConfigKeys.GOBBLIN_SERVICE_FLOWCOMPILER_CLASS_KEY);

Review Comment:
   what about this one:
   ```
   String ConfigUtils::getString(Config config, String path, String def)
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org