You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by el...@apache.org on 2011/11/20 05:13:32 UTC
svn commit: r1204122 - in
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt
src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
Author: eli
Date: Sun Nov 20 04:13:32 2011
New Revision: 1204122
URL: http://svn.apache.org/viewvc?rev=1204122&view=rev
Log:
HDFS-2568. Use a set to manage child sockets in XceiverServer. Contributed by Harsh J
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1204122&r1=1204121&r2=1204122&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Sun Nov 20 04:13:32 2011
@@ -124,6 +124,9 @@ Release 0.23.1 - UNRELEASED
HDFS-208. name node should warn if only one dir is listed in dfs.name.dir.
(Uma Maheswara Rao G via eli)
+ HDFS-2568. Use a set to manage child sockets in XceiverServer.
+ (harsh via eli)
+
HDFS-2536. Remove unused imports. (harsh via eli)
OPTIMIZATIONS
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java?rev=1204122&r1=1204121&r2=1204122&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java Sun Nov 20 04:13:32 2011
@@ -126,7 +126,7 @@ class DataXceiver extends Receiver imple
public void run() {
int opsProcessed = 0;
Op op = null;
- dataXceiverServer.childSockets.put(s, s);
+ dataXceiverServer.childSockets.add(s);
try {
int stdTimeout = s.getSoTimeout();
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java?rev=1204122&r1=1204121&r2=1204122&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java Sun Nov 20 04:13:32 2011
@@ -23,9 +23,9 @@ import java.net.Socket;
import java.net.SocketTimeoutException;
import java.nio.channels.AsynchronousCloseException;
import java.util.Collections;
-import java.util.HashMap;
+import java.util.HashSet;
import java.util.Iterator;
-import java.util.Map;
+import java.util.Set;
import org.apache.commons.logging.Log;
import org.apache.hadoop.conf.Configuration;
@@ -48,8 +48,8 @@ class DataXceiverServer implements Runna
ServerSocket ss;
DataNode datanode;
// Record all sockets opened for data transfer
- Map<Socket, Socket> childSockets = Collections.synchronizedMap(
- new HashMap<Socket, Socket>());
+ Set<Socket> childSockets = Collections.synchronizedSet(
+ new HashSet<Socket>());
/**
* Maximal number of concurrent xceivers per node.
@@ -184,7 +184,7 @@ class DataXceiverServer implements Runna
// close all the sockets that were accepted earlier
synchronized (childSockets) {
- for (Iterator<Socket> it = childSockets.values().iterator();
+ for (Iterator<Socket> it = childSockets.iterator();
it.hasNext();) {
Socket thissock = it.next();
try {