You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/01/09 20:26:09 UTC

[GitHub] storm-site pull request #3: Update README, the guide for building the site w...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm-site/pull/3

    Update README, the guide for building the site was not correct

    The README contains a lot of references to the SVN repository. It also doesn't mention how to fetch the site dependencies (github-pages).
    
    I think the section at the top about generating javadoc is confusing, it's something you have to do in the main Storm repository but it's not mentioned. Since it's mentioned under the procedure for creating a new release, I've removed the description at the top.
    
    There is no /publish directory in the repository, so I think the description of how to publish is out of date. Does the site automatically get updated when we push to the asf-site branch? I've removed the bit about /publish, since it doesn't make sense, but I'd like to replace it with a description of how publishing actually happens.
    
    The bit about the release plugin and extracting the version from the maven pom doesn't make sense, since the site is not in the same repository as the Storm source anymore. I've removed it. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm-site fix-readme

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm-site/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit aa0218553ad8e814cbfac450e4a58703f8e44cd9
Author: Stig Rohde Døssing <st...@...>
Date:   2018-01-09T19:02:00Z

    Update README, the guide for building the site was not correct

----


---

[GitHub] storm-site pull request #3: Update README, the guide for building the site w...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm-site/pull/3


---

[GitHub] storm-site issue #3: Update README, the guide for building the site was not ...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm-site/pull/3
  
    Thanks @srdo, merged into asf-site.


---

[GitHub] storm-site issue #3: Update README, the guide for building the site was not ...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm-site/pull/3
  
    Updated the README with my best guess for how we publish the site.


---