You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/07 16:39:00 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
rkhachatryan opened a new pull request #14582:
URL: https://github.com/apache/flink/pull/14582
This is a backport of #14581 to 1.12.
## What is the purpose of the change
In regard to InputChannels, there are 3 cases when a checkpoint has to be declined:
1. Channel state is not fully consumed
2. Channel was not yet converted from Recovered to normal
3. Channel was not yet converted from Unknown to normal
In the 1st case, new checkpoint may skip some recovered buffers.
In the 2nd and 3rd cases, not handling checkpointStarted() call
by normal channels can prevent incoming buffers from being captured.
In all these cases new checkpoint would be inconsistent.
## Verifying this change
- Re-enabled existing `UnalignedCheckpointITCase` (union)
- Added unit tests for channels (RecoveredInputChannelTest.#testCheckpointStartImpossible, SingleInputGateTest.testCheckpointsDeclinedUnlessAllChannelsAreKnown)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756241128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "994695461ddaaea326b151ab7eabe3205586f90a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "994695461ddaaea326b151ab7eabe3205586f90a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 994695461ddaaea326b151ab7eabe3205586f90a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756241128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "994695461ddaaea326b151ab7eabe3205586f90a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11758",
"triggerID" : "994695461ddaaea326b151ab7eabe3205586f90a",
"triggerType" : "PUSH"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766",
"triggerID" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 47b174536f703359fb84e1e7f567430b8ac49aa9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #14582:
URL: https://github.com/apache/flink/pull/14582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756241128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "994695461ddaaea326b151ab7eabe3205586f90a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11758",
"triggerID" : "994695461ddaaea326b151ab7eabe3205586f90a",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766",
"triggerID" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 47b174536f703359fb84e1e7f567430b8ac49aa9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756241128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "994695461ddaaea326b151ab7eabe3205586f90a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11758",
"triggerID" : "994695461ddaaea326b151ab7eabe3205586f90a",
"triggerType" : "PUSH"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "756317504",
"triggerType" : "MANUAL"
}, {
"hash" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "47b174536f703359fb84e1e7f567430b8ac49aa9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 47b174536f703359fb84e1e7f567430b8ac49aa9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756231772
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 994695461ddaaea326b151ab7eabe3205586f90a (Thu Jan 07 16:41:37 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756317504
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756241128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "994695461ddaaea326b151ab7eabe3205586f90a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11758",
"triggerID" : "994695461ddaaea326b151ab7eabe3205586f90a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 994695461ddaaea326b151ab7eabe3205586f90a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11758)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14582: (backport 1.12) [FLINK-20654][checkpointing] Decline checkpoint until input channel is recovered
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14582:
URL: https://github.com/apache/flink/pull/14582#issuecomment-756231772
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 47b174536f703359fb84e1e7f567430b8ac49aa9 (Fri May 28 07:02:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org