You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/06 22:02:43 UTC

[GitHub] [pulsar] dlg99 opened a new pull request, #15053: Deprecate org.apache.pulsar.io.core.KeyValue

dlg99 opened a new pull request, #15053:
URL: https://github.com/apache/pulsar/pull/15053

   Fixes #15027 
   
   ### Motivation
   
   We have org.apache.pulsar.common.schema.KeyValue and org.apache.pulsar.io.core.KeyValue.
   io.core.KeyValue is limited to pulsar-io and can be safely replaced by common.schema.KeyValue or some Pair implementation.
   
   ### Modifications
   
   Marked the class as deprecated (can't just delete it since it is a Public/Stable).
   Replaced all its usages with common.schema.KeyValue (except for the pulsar-io/kafka-connect-adaptor - https://github.com/apache/pulsar/pull/15025 will take care of that)
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: *YES, org.apache.pulsar.io.core.KeyValue is deprecated*
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
   Javadoc / release notes should be enough  
   
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15053: Deprecate org.apache.pulsar.io.core.KeyValue

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15053:
URL: https://github.com/apache/pulsar/pull/15053#issuecomment-1133500126

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed pull request #15053: Deprecate org.apache.pulsar.io.core.KeyValue

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #15053: Deprecate org.apache.pulsar.io.core.KeyValue
URL: https://github.com/apache/pulsar/pull/15053


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15053: Deprecate org.apache.pulsar.io.core.KeyValue

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15053:
URL: https://github.com/apache/pulsar/pull/15053#issuecomment-1159892188

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #15053: Deprecate org.apache.pulsar.io.core.KeyValue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15053:
URL: https://github.com/apache/pulsar/pull/15053#issuecomment-1345240210

   Closed as stale, conflict, and no consensus. Please rebase and resubmit the patch if it's still relevant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org