You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sam Okrent (Code Review)" <ge...@cloudera.org> on 2017/06/26 21:11:17 UTC
[kudu-CR] Add mustache as a dependency
Sam Okrent has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7298
Change subject: Add mustache as a dependency
......................................................................
Add mustache as a dependency
Mustache is a popular template engine. The version
added by this commit is a C++ implementation found
at https://github.com/henryr/cpp-mustache. Mustache
is intended to be use for rendering HTML pages in
the kudu webserver.
Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
---
M CMakeLists.txt
A cmake_modules/FindMustache.cmake
M src/kudu/server/default-path-handlers.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/7298/1
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
[kudu-CR] Add mustache as a dependency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7298/3/thirdparty/LICENSE.txt
File thirdparty/LICENSE.txt:
Line 246: -------------------------------------------------------------------------------
Nit: looks like you left off a dash or two here. Can't tell which of the two lines is more consistent with the others in this file, but there's definitely a discrepancy between them.
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Sam Okrent has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 4:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7298/2//COMMIT_MSG
Commit Message:
Line 7: Add mustache as a dependency
> Please also add an entry in thirdparty/LICENSE.txt
Done
http://gerrit.cloudera.org:8080/#/c/7298/2/CMakeLists.txt
File CMakeLists.txt:
Line 860: ## OpenSSL
> extra newline
Done
http://gerrit.cloudera.org:8080/#/c/7298/3/thirdparty/LICENSE.txt
File thirdparty/LICENSE.txt:
Line 246: --------------------------------------------------------------------------------
> Nit: looks like you left off a dash or two here. Can't tell which of the tw
Done
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Line 503: # We add $PREFIX/include for boost and $PREFIX_COMMON/include for rapidjson.
> You can use PREFIX_COMMON for $TP_DIR/installed/common. Please also add a c
Done
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 99: # (from https://github.com/henryr/cpp-mustache)
> extra whitespace
Done
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Add mustache as a dependency
......................................................................
Add mustache as a dependency
Mustache is a popular template engine. The version
added by this commit is a C++ implementation found
at https://github.com/henryr/cpp-mustache. Mustache
is intended to be use for rendering HTML pages in
the kudu webserver.
Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Reviewed-on: http://gerrit.cloudera.org:8080/7298
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
A cmake_modules/FindMustache.cmake
M src/kudu/server/default-path-handlers.cc
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
8 files changed, 82 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7298
to look at the new patch set (#4).
Change subject: Add mustache as a dependency
......................................................................
Add mustache as a dependency
Mustache is a popular template engine. The version
added by this commit is a C++ implementation found
at https://github.com/henryr/cpp-mustache. Mustache
is intended to be use for rendering HTML pages in
the kudu webserver.
Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
---
M CMakeLists.txt
A cmake_modules/FindMustache.cmake
M src/kudu/server/default-path-handlers.cc
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
8 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/7298/4
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Sam Okrent has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Line 503: ${CXX:-g++} $EXTRA_CXX_FLAGS -I$PREFIX/include -I$TP_DIR/installed/common/include -O3 -DNDEBUG -fPIC -c "$MUSTACHE_SOURCE/mustache.cc"
> EXTRA_CXX_FLAGS isn't a real variable; I think you meant EXTRA_CXXFLAGS her
Woops that is correct. Mustache depends on boost and rapidjson. The second -I could be changed to -I$MUSTACHE_SOURCE/thirdparty/rapidjson/include, as mustache contains the rapidjson headers it needs, but not boost
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7298
to look at the new patch set (#3).
Change subject: Add mustache as a dependency
......................................................................
Add mustache as a dependency
Mustache is a popular template engine. The version
added by this commit is a C++ implementation found
at https://github.com/henryr/cpp-mustache. Mustache
is intended to be use for rendering HTML pages in
the kudu webserver.
Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
---
M CMakeLists.txt
A cmake_modules/FindMustache.cmake
M src/kudu/server/default-path-handlers.cc
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
8 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/7298/3
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Add mustache as a dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] Add mustache as a dependency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Line 503: ${CXX:-g++} $EXTRA_CXX_FLAGS -I$PREFIX/include -I$TP_DIR/installed/common/include -O3 -DNDEBUG -fPIC -c "$MUSTACHE_SOURCE/mustache.cc"
> Woops that is correct. Mustache depends on boost and rapidjson. The second
You can use PREFIX_COMMON for $TP_DIR/installed/common. Please also add a comment here describing mustache's dependencies. Something like "We add $PREFIX/include for boost and $PREFIX_COMMON/include for rapidjson.
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Sam Okrent has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7298/2/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
Line 31: #include <mustache.h>
> The changes in this file aren't needed, right?
No they're not needed, they were just to show that it's included correctly
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Line 503: ${CXX:-g++} $EXTRA_CXX_FLAGS -I$PREFIX/include -I$TP_DIR/installed/common/include -O3 -DNDEBUG -fPIC -c "$MUSTACHE_SOURCE/mustache.cc"
EXTRA_CXX_FLAGS isn't a real variable; I think you meant EXTRA_CXXFLAGS here.
Also, why do we need these -I entries?
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] Add mustache as a dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add mustache as a dependency
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7298/2//COMMIT_MSG
Commit Message:
Line 7: Add mustache as a dependency
Please also add an entry in thirdparty/LICENSE.txt
http://gerrit.cloudera.org:8080/#/c/7298/2/CMakeLists.txt
File CMakeLists.txt:
Line 860:
extra newline
http://gerrit.cloudera.org:8080/#/c/7298/2/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
Line 31: #include <mustache.h>
The changes in this file aren't needed, right?
http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 99: # (from https://github.com/henryr/cpp-mustache)
extra whitespace
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Add mustache as a dependency
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Sam Okrent has uploaded a new patch set (#2).
Change subject: Add mustache as a dependency
......................................................................
Add mustache as a dependency
Mustache is a popular template engine. The version
added by this commit is a C++ implementation found
at https://github.com/henryr/cpp-mustache. Mustache
is intended to be use for rendering HTML pages in
the kudu webserver.
Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
---
M CMakeLists.txt
A cmake_modules/FindMustache.cmake
M src/kudu/server/default-path-handlers.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
7 files changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/7298/2
--
To view, visit http://gerrit.cloudera.org:8080/7298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins