[jira] [Updated] (MAPREDUCE-2445) TestMiniMRWithDFSWithDistinctUsers is very broken

["Todd Lipcon (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-2445:
-----------------------------------

    Attachment: mapreduce-2445.txt

Here's a fixed up test case:
- renamed "wc" and "pi" users to "alice" and "bob", since in fact both are running wordcount
- set up a proper staging directory with sticky bit, etc, so job can be successfully submitted
- sets up home directories for each user that are only writable by them (to make sure that the job is running as the right users)
- avoids using internal job submission APIs, so job actually submits
- checks return status of job to actually assert success
- shuts down services in correct order

> TestMiniMRWithDFSWithDistinctUsers is very broken
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2445
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2445
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security, test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2445.txt
>
>
> This test has a number of issues:
> - it side steps the normal job submission API for no apparent reason, manually writing splits file and uploading submission files. (but forgets to upload the job jar, so the jobs all fail)
> - it doesn't call waitForCompletion, or check job status (so it doesn't notice that the jobs all fail)
> - it doesn't verify in any way that the job output is owned by the user who supposedly ran the job
> - it shuts down DFS before MR
> These all conspire to make it pass, but it isn't actually testing anything.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira