You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/02/27 06:26:45 UTC

[jira] [Comment Edited] (SLING-6567) BasicObservationReporter ignores resource changes for resource providers mounted at specific paths

    [ https://issues.apache.org/jira/browse/SLING-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885229#comment-15885229 ] 

Carsten Ziegeler edited comment on SLING-6567 at 2/27/17 6:25 AM:
------------------------------------------------------------------

[~sseifert@pro-vision.de] Yes, I think you're right and the patch lgtm. The only thing I would add is a check if "p" is not a pattern:
{code}
(!p.isPattern() && p.matches(providerPath.getPath())
{code}
though I'm not quiet sure why ...


was (Author: cziegeler):
[~sseifert@pro-vision.de] Yes, I think you're right and the patch lgtm. The only thing I would add is a check if "p" is not a pattern:
{code}
(!p.isPattern() && p.matches(providerPath.getPath())
{code}
not quiet sure, why though

> BasicObservationReporter ignores resource changes for resource providers mounted at specific paths
> --------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6567
>                 URL: https://issues.apache.org/jira/browse/SLING-6567
>             Project: Sling
>          Issue Type: Bug
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.5.14
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>             Fix For: Resource Resolver 1.5.16
>
>         Attachments: SLING-6567.patch
>
>
> with the new resource provider SPI an intelligent ResourceListener mechanism was introduced which allows to generate and route resource change events only when a listener is actual interested in this change. this works well when the resource provider is a root provider mounted at {{/}}.
> however this currently fails when an additional resource provider is mounted at a specific path - e.g. at {{/apps/app1}}. in this case listeners mounted to specific glob patterns like {{glob:/apps/**/*.html}} get the changes reported by the resource provider, but listeners registered to {{/}} do not.
> this is a severe problem as some listeners like the script resolution cache are registered to {{/}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)