[GitHub] [logging-log4j2] carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be constructed using a builder pattern

[GitBox <gi...@apache.org>]

carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-504775782
 
 
   > Calling log twice on the same LogBuilder would result in 2 identical log messages, other than the timestamp
   
   I think parameter values are mutated in gc free mode after the first event is logged, I would expect the second invocation (assuming it is executed after a few microseconds) would have all null parameters.
   
   > We could easily add the current thread id to DefaultLogBuilder to verify it is only used on a single thread but is it worth the overhead of checking that on every method call?
   
   Maybe only the `log()` invocation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services