You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by johnsca <gi...@git.apache.org> on 2016/06/10 23:24:29 UTC
[GitHub] bigtop pull request #120: BIGTOP-2480: Fix occasional timeout on hadoop-proc...
GitHub user johnsca opened a pull request:
https://github.com/apache/bigtop/pull/120
BIGTOP-2480: Fix occasional timeout on hadoop-processing Juju bundle
During test runs, we are sometimes seeing the bundle test timeout during the initial deploy on slow clouds. GCE in particular is slow to deploy (but is faster once deployed, go figure).
There is a feature of the bundletester tool which can be used to increase the deployment timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop BIGTOP-2480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 1ab070ed85a31cc899bd78f10db379d5dc68ab69
Author: Cory Johns <jo...@gmail.com>
Date: 2016-06-10T21:19:56Z
BIGTOP-2480: Fix occasional timeout on hadoop-processing Juju bundle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #120: BIGTOP-2480: Fix occasional timeout on hadoop-processing ...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/120
Let's kill this JIRA/PR @johnsca.. I've added `deployment_timeout` to the bundle refresh jira, which already bumped charm revnos:
https://issues.apache.org/jira/browse/BIGTOP-2550
Code:
https://github.com/juju-solutions/bigtop/blob/feature/BIGTOP-2550/bundle-to-xenial/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml#L2
```diff
--- a/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml
+++ b/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml
@@ -1,4 +1,5 @@
reset: false
+deployment_timeout: 3600
packages:
- amulet
- python3-yaml
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #120: BIGTOP-2480: Fix occasional timeout on hadoop-processing ...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/120
@johnsca is this still valid? It's not clear to me how `00-deploy` is doing anything different than `01-deploy.py` is doing with its `d.setup` and `wait_for_messages` calls:
https://github.com/apache/bigtop/blob/master/bigtop-deploy/juju/hadoop-processing/tests/01-bundle.py#L37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #120: BIGTOP-2480: Fix occasional timeout on hadoop-proc...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca closed the pull request at:
https://github.com/apache/bigtop/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #120: BIGTOP-2480: Fix occasional timeout on hadoop-processing ...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca commented on the issue:
https://github.com/apache/bigtop/pull/120
@kwmonroe Yes, the motivation behind this change is still valid but there is now another, cleaner way to get the same result.
The difference between `00-deploy` and `01-bundle` is that the former is being used as a pre-deploy step ([line 2](https://github.com/apache/bigtop/pull/120/files#diff-707de698394ac34e432f2dec065a7916R2) in `tests.yaml`). This lets us override the timeout of the initial deploy and at the time of this PR's submission was the only way to do so. juju-solutions/bundletester#50 has since been released, however, so we could replace `00-deploy` and the `bundle_deploy` option with the `deployment_timeout` option.
I can update this PR, or close and submit a new one.
Oh, and I also think its worthwhile to rev the charms to the most recent versions, yes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---