[GitHub] [incubator-superset] etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock

[GitBox <gi...@apache.org>]

etr2460 commented on issue #8262: [SQL Lab] Add commit to resolve query table lock
URL: https://github.com/apache/incubator-superset/pull/8262#issuecomment-533651389
 
 
   @villebro There is a commit prior to calling `execute_sql_statement`, but then the query object is potentially modified again prior to running the query (setting `query.tmp_table_name`, `query.select_as_cta_used`, `query.limit`, and `query.executed_sql`). Since autoflush is enabled, I believe this is being sent to the db and locking the row for updates, and the lock isn't removed until significantly later.
   
   This happened about 100-200 times a day, sometimes more, and was in line with our general usage stats (which makes sense, people would see it more often if they were running queries more often). I was able to get logs showing that the specific row in the query table was locked for updating, and all instances of this error went away after deploying this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org