[jira] [Comment Edited] (THRIFT-3886) PHP cross test client returns 0 even when failing

["Aki Sukegawa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717474#comment-15717474 ] 

Aki Sukegawa edited comment on THRIFT-3886 at 12/3/16 5:52 AM:
---------------------------------------------------------------

[~jensg] sorry, I've overlooked your comment too.
It's fine, this one is on top of my commit and covers much more cases.
A sub-task for the commit might have been cleaner, though.

edit:
[~hakon] I realised that this one is effectvely a test case for the other patch THRIFT-3348.
Can you rebase or merge your pull request on master ?


was (Author: nsuke):
[~jensg] sorry, I've overlooked your comment too.
It's fine, this one is on top of my commit and covers much more cases.
A sub-task for the commit might have been cleaner, though.

[~hakon] the failures seem to be Compact protocol tests for `-9223372036854775808`.
It turned out that PHP Compact protocol is turning that particular value into a floating point on PHP 5.5.
Will merge yours after fixing it.

> PHP cross test client returns 0 even when failing
> -------------------------------------------------
>
>                 Key: THRIFT-3886
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3886
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library, Test Suite
>            Reporter: Aki Sukegawa
>
> PHP cross test client never fails on invalid values.
> update:
> Results for primitive values are now validated after PR #1054.
> Structs, containers, etc are still affected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)