You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Timothy Potter <th...@apache.org> on 2021/09/28 20:32:33 UTC
8.10 docker image please
can someone who has done this before please publish the 8.10 Docker
image now that the release is done
thanks.
Tim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: 8.10 docker image please
Posted by David Smiley <ds...@apache.org>.
FYI official-images PR is now submitted:
https://github.com/docker-library/official-images/pull/11000
Thanks for your help Hoss!
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Thu, Sep 30, 2021 at 1:32 PM Chris Hostetter <ho...@fucit.org>
wrote:
>
> David: I submitte a PR to docker-solr to hardocde the archs for 6.* and
> 5.* releases in generate-stackbrew-library.sh
>
> https://github.com/docker-solr/docker-solr/pull/388
>
> I'll let you RTC and deal with the final docker-library/official-images PR
> since I have no established credibility with docker-library to broach the
> "our GitCommit for 8.9 doesn't exist, why is your tooling not freaking out
> about this and how is the 8.9 version being built as a result?" portion of
> the discussion. :)
>
>
>
> : Date: Thu, 30 Sep 2021 00:10:50 -0400
> : From: David Smiley <ds...@apache.org>
> : Reply-To: dev@solr.apache.org
> : To: dev@solr.apache.org
> : Subject: Re: 8.10 docker image please
> :
> : I dug into this some. The 8.9 commit hash there (a1a59) was incorrect;
> it
> : was for a PR that after merging became something else.
> : https://github.com/docker-solr/docker-solr/pull/380 (see first commit in
> : there).
> : The official-docker-images PR was crafted prematurely by the contributor.
> : I'm not sure what consequence this has but it ought to be pointed out in
> : our 8.10 PR to official-images.
> :
> : Regarding the arm64v8 tags, those should be removed manually, or fix the
> : root cause that probably lies in that generate-stackbrew-library.sh
> : script. See the PR comments about that here:
> : https://github.com/docker-library/official-images/pull/10403
> :
> : I can do these things tomorrow at some point.
> :
> : ~ David Smiley
> : Apache Lucene/Solr Search Developer
> : http://www.linkedin.com/in/davidwsmiley
> :
> :
> : On Wed, Sep 29, 2021 at 10:03 PM Chris Hostetter <ho...@fucit.org>
> wrote:
> :
> : >
> : > : 2) changing the GitCommit associated with 8.9.0
> : > :
> : > : ...the last one is the biggest WTF, allthough frankly the 'new'
> : > GitCommit
> : > : seems "correct" while the 'old' GitCommit (currently listed in
> : > : docker-library/official-images.git's copy of library/solr) doesn't
> exist
> : > : at all in docker-solr/docker-solr.git AFAICT -- which defeats the
> point
> : > of
> : > : this GitCommit in the manifest file as i understand it -- so i really
> : > have
> : > : no idea WTF is going on, or if any of this is "correct" ...
> : >
> : > Hmmm....
> : >
> : > (Manually crafted URL to see what github thinks about it)
> : >
> : >
> https://github.com/docker-solr/docker-solr/commit/a1a59aa9d3ef286fe1e046ddfd168c3c34720660
> : >
> : > "This commit does not belong to any branch on this repository, and may
> : > belong to a fork outside of the repository."
> : >
> : >
> : > ...so how/why does the current library/solr file in
> : > docker-library/official-images.git "work" in it's current state? does
> : > docker-library really just not care at all about the GitCommit when
> : > generating official images?
> : >
> : >
> : >
> : > -Hoss
> : >
> : > ---------------------------------------------------------------------
> : > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> : > For additional commands, e-mail: dev-help@solr.apache.org
> : >
> : >
> :
>
> -Hoss
> http://www.lucidworks.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
Re: 8.10 docker image please
Posted by Chris Hostetter <ho...@fucit.org>.
David: I submitte a PR to docker-solr to hardocde the archs for 6.* and
5.* releases in generate-stackbrew-library.sh
https://github.com/docker-solr/docker-solr/pull/388
I'll let you RTC and deal with the final docker-library/official-images PR
since I have no established credibility with docker-library to broach the
"our GitCommit for 8.9 doesn't exist, why is your tooling not freaking out
about this and how is the 8.9 version being built as a result?" portion of
the discussion. :)
: Date: Thu, 30 Sep 2021 00:10:50 -0400
: From: David Smiley <ds...@apache.org>
: Reply-To: dev@solr.apache.org
: To: dev@solr.apache.org
: Subject: Re: 8.10 docker image please
:
: I dug into this some. The 8.9 commit hash there (a1a59) was incorrect; it
: was for a PR that after merging became something else.
: https://github.com/docker-solr/docker-solr/pull/380 (see first commit in
: there).
: The official-docker-images PR was crafted prematurely by the contributor.
: I'm not sure what consequence this has but it ought to be pointed out in
: our 8.10 PR to official-images.
:
: Regarding the arm64v8 tags, those should be removed manually, or fix the
: root cause that probably lies in that generate-stackbrew-library.sh
: script. See the PR comments about that here:
: https://github.com/docker-library/official-images/pull/10403
:
: I can do these things tomorrow at some point.
:
: ~ David Smiley
: Apache Lucene/Solr Search Developer
: http://www.linkedin.com/in/davidwsmiley
:
:
: On Wed, Sep 29, 2021 at 10:03 PM Chris Hostetter <ho...@fucit.org> wrote:
:
: >
: > : 2) changing the GitCommit associated with 8.9.0
: > :
: > : ...the last one is the biggest WTF, allthough frankly the 'new'
: > GitCommit
: > : seems "correct" while the 'old' GitCommit (currently listed in
: > : docker-library/official-images.git's copy of library/solr) doesn't exist
: > : at all in docker-solr/docker-solr.git AFAICT -- which defeats the point
: > of
: > : this GitCommit in the manifest file as i understand it -- so i really
: > have
: > : no idea WTF is going on, or if any of this is "correct" ...
: >
: > Hmmm....
: >
: > (Manually crafted URL to see what github thinks about it)
: >
: > https://github.com/docker-solr/docker-solr/commit/a1a59aa9d3ef286fe1e046ddfd168c3c34720660
: >
: > "This commit does not belong to any branch on this repository, and may
: > belong to a fork outside of the repository."
: >
: >
: > ...so how/why does the current library/solr file in
: > docker-library/official-images.git "work" in it's current state? does
: > docker-library really just not care at all about the GitCommit when
: > generating official images?
: >
: >
: >
: > -Hoss
: >
: > ---------------------------------------------------------------------
: > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
: > For additional commands, e-mail: dev-help@solr.apache.org
: >
: >
:
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: 8.10 docker image please
Posted by David Smiley <ds...@apache.org>.
I dug into this some. The 8.9 commit hash there (a1a59) was incorrect; it
was for a PR that after merging became something else.
https://github.com/docker-solr/docker-solr/pull/380 (see first commit in
there).
The official-docker-images PR was crafted prematurely by the contributor.
I'm not sure what consequence this has but it ought to be pointed out in
our 8.10 PR to official-images.
Regarding the arm64v8 tags, those should be removed manually, or fix the
root cause that probably lies in that generate-stackbrew-library.sh
script. See the PR comments about that here:
https://github.com/docker-library/official-images/pull/10403
I can do these things tomorrow at some point.
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Wed, Sep 29, 2021 at 10:03 PM Chris Hostetter <ho...@fucit.org> wrote:
>
> : 2) changing the GitCommit associated with 8.9.0
> :
> : ...the last one is the biggest WTF, allthough frankly the 'new'
> GitCommit
> : seems "correct" while the 'old' GitCommit (currently listed in
> : docker-library/official-images.git's copy of library/solr) doesn't exist
> : at all in docker-solr/docker-solr.git AFAICT -- which defeats the point
> of
> : this GitCommit in the manifest file as i understand it -- so i really
> have
> : no idea WTF is going on, or if any of this is "correct" ...
>
> Hmmm....
>
> (Manually crafted URL to see what github thinks about it)
>
> https://github.com/docker-solr/docker-solr/commit/a1a59aa9d3ef286fe1e046ddfd168c3c34720660
>
> "This commit does not belong to any branch on this repository, and may
> belong to a fork outside of the repository."
>
>
> ...so how/why does the current library/solr file in
> docker-library/official-images.git "work" in it's current state? does
> docker-library really just not care at all about the GitCommit when
> generating official images?
>
>
>
> -Hoss
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
Re: 8.10 docker image please
Posted by Chris Hostetter <ho...@fucit.org>.
: 2) changing the GitCommit associated with 8.9.0
:
: ...the last one is the biggest WTF, allthough frankly the 'new' GitCommit
: seems "correct" while the 'old' GitCommit (currently listed in
: docker-library/official-images.git's copy of library/solr) doesn't exist
: at all in docker-solr/docker-solr.git AFAICT -- which defeats the point of
: this GitCommit in the manifest file as i understand it -- so i really have
: no idea WTF is going on, or if any of this is "correct" ...
Hmmm....
(Manually crafted URL to see what github thinks about it)
https://github.com/docker-solr/docker-solr/commit/a1a59aa9d3ef286fe1e046ddfd168c3c34720660
"This commit does not belong to any branch on this repository, and may
belong to a fork outside of the repository."
...so how/why does the current library/solr file in
docker-library/official-images.git "work" in it's current state? does
docker-library really just not care at all about the GitCommit when
generating official images?
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: 8.10 docker image please
Posted by Chris Hostetter <ho...@fucit.org>.
: I granted Hossman access.
So.... thanks ... but i don't really understand what is suppose to happen
now?
: I also reviewed the Travis-CI integration and for some reason it just isn't
: working. Not critical though -- just need to test manually.
Yeah ... I know nothing about Travis CI (not sure why Jan thought I'd be
able to help figure that out)
...but I did attempt to follow the remaining steps in updated.md with my
new access...
https://github.com/docker-solr/docker-solr/blob/master/update.md#update-the-official-images-repository
But 2/3rds of what I saw made no sense to me...
>> git rev-parse HEAD
>> Make note of that git SHA.
Why? nothing in the instructions after this say what you should do with
that SHA that you made a note of
>> Now we turn to the docker-solr fork of the official-images repository.
>> Clone the repo, and bring it up-to-date with the latest changes from
>> upstream:
I did this, and it worked, but oddly docker-solr/official-images was
so old (prior to me bring it up to date) that it didn't even have Solr
8.9.0 listed in it?????
>> cat ../new-versions > library/solr
>> git diff
>>
>> If that all looks plausible, push to master on our fork:
It does *NOT* look plausible...
generate-stackbrew-library.sh seems to have made two modifications
that don't corrispond with adding 8.10 (see diff below) ...
1) adding arm64v8 to the Architectures list of 5.5.5 and 6.6.6
2) changing the GitCommit associated with 8.9.0
...the last one is the biggest WTF, allthough frankly the 'new' GitCommit
seems "correct" while the 'old' GitCommit (currently listed in
docker-library/official-images.git's copy of library/solr) doesn't exist
at all in docker-solr/docker-solr.git AFAICT -- which defeats the point of
this GitCommit in the manifest file as i understand it -- so i really have
no idea WTF is going on, or if any of this is "correct" ...
-Hoss
http://www.lucidworks.com/
diff --git a/library/solr b/library/solr
index a9f2e2781..9b0e6304c 100644
--- a/library/solr
+++ b/library/solr
@@ -6,14 +6,24 @@ Maintainers: The Apache Lucene/Solr Project <so...@lucene.apache.org> (@asfb
Jan Høydahl (@janhoy)
GitRepo: https://github.com/docker-solr/docker-solr.git
-Tags: 8.9.0, 8.9, 8, latest
+Tags: 8.10.0, 8.10, 8, latest
Architectures: amd64, arm64v8
-GitCommit: a1a59aa9d3ef286fe1e046ddfd168c3c34720660
+GitCommit: c9e67796b9620b9f93973b2667837ae47cc83b8f
+Directory: 8.10
+
+Tags: 8.10.0-slim, 8.10-slim, 8-slim, slim
+Architectures: amd64, arm64v8
+GitCommit: c9e67796b9620b9f93973b2667837ae47cc83b8f
+Directory: 8.10/slim
+
+Tags: 8.9.0, 8.9
+Architectures: amd64, arm64v8
+GitCommit: b786d89646823e5250368cb25fa2f55fdc50ec7e
Directory: 8.9
-Tags: 8.9.0-slim, 8.9-slim, 8-slim, slim
+Tags: 8.9.0-slim, 8.9-slim
Architectures: amd64, arm64v8
-GitCommit: a1a59aa9d3ef286fe1e046ddfd168c3c34720660
+GitCommit: b786d89646823e5250368cb25fa2f55fdc50ec7e
Directory: 8.9/slim
Tags: 8.8.2, 8.8
@@ -117,21 +127,21 @@ GitCommit: 86159575c4b6da2010ae9ee003bf5a6de31157cb
Directory: 7.7/slim
Tags: 6.6.6, 6.6, 6
-Architectures: amd64
+Architectures: amd64, arm64v8
GitCommit: 86159575c4b6da2010ae9ee003bf5a6de31157cb
Directory: 6.6
Tags: 6.6.6-slim, 6.6-slim, 6-slim
-Architectures: amd64
+Architectures: amd64, arm64v8
GitCommit: 86159575c4b6da2010ae9ee003bf5a6de31157cb
Directory: 6.6/slim
Tags: 5.5.5, 5.5, 5
-Architectures: amd64
+Architectures: amd64, arm64v8
GitCommit: 86159575c4b6da2010ae9ee003bf5a6de31157cb
Directory: 5.5
Tags: 5.5.5-slim, 5.5-slim, 5-slim
-Architectures: amd64
+Architectures: amd64, arm64v8
GitCommit: 86159575c4b6da2010ae9ee003bf5a6de31157cb
Directory: 5.5/slim
Re: 8.10 docker image please
Posted by David Smiley <ds...@apache.org>.
I granted Hossman access.
I also reviewed the Travis-CI integration and for some reason it just isn't
working. Not critical though -- just need to test manually.
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Tue, Sep 28, 2021 at 6:57 PM Jan Høydahl <ja...@cominvent.com> wrote:
> I merged the PR, but it was perhaps premature. According to update.md
> we're supposed to see a green Travis build.
> However, the travis build does not seem to kick off at
> https://app.travis-ci.com/github/docker-solr/docker-solr/builds (the .org
> address does not work), and I don't have karma to manually kick it off.
>
> David, can you perhaps give Hoss karma to the docker-solr repo so he can
> play around? I am a Member but not a Maintainer so I cannot do it.
>
> Jan
>
> > 28. sep. 2021 kl. 23:40 skrev Chris Hostetter <hossman_lucene@fucit.org
> >:
> >
> > On Tue, 28 Sep 2021, Timothy Potter wrote:
> >
> > : Date: Tue, 28 Sep 2021 14:32:33 -0600
> > : From: Timothy Potter <th...@apache.org>
> > : Reply-To: dev@solr.apache.org
> > : To: Solr Dev <de...@solr.apache.org>
> > : Subject: 8.10 docker image please
> > :
> > : can someone who has done this before please publish the 8.10 Docker
> > : image now that the release is done
> >
> > I (fixed and) ran the update script, and ran the scripted tests on the
> > resulting image, PR online...
> >
> > https://github.com/docker-solr/docker-solr/pull/387
> >
> > ...some one with docker-solr karma has to take the last few inches over
> > the finish line.
> >
> >
> > -Hoss
> > http://www.lucidworks.com/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> > For additional commands, e-mail: dev-help@solr.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
Re: 8.10 docker image please
Posted by Jan Høydahl <ja...@cominvent.com>.
I merged the PR, but it was perhaps premature. According to update.md we're supposed to see a green Travis build.
However, the travis build does not seem to kick off at https://app.travis-ci.com/github/docker-solr/docker-solr/builds (the .org address does not work), and I don't have karma to manually kick it off.
David, can you perhaps give Hoss karma to the docker-solr repo so he can play around? I am a Member but not a Maintainer so I cannot do it.
Jan
> 28. sep. 2021 kl. 23:40 skrev Chris Hostetter <ho...@fucit.org>:
>
> On Tue, 28 Sep 2021, Timothy Potter wrote:
>
> : Date: Tue, 28 Sep 2021 14:32:33 -0600
> : From: Timothy Potter <th...@apache.org>
> : Reply-To: dev@solr.apache.org
> : To: Solr Dev <de...@solr.apache.org>
> : Subject: 8.10 docker image please
> :
> : can someone who has done this before please publish the 8.10 Docker
> : image now that the release is done
>
> I (fixed and) ran the update script, and ran the scripted tests on the
> resulting image, PR online...
>
> https://github.com/docker-solr/docker-solr/pull/387
>
> ...some one with docker-solr karma has to take the last few inches over
> the finish line.
>
>
> -Hoss
> http://www.lucidworks.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: 8.10 docker image please
Posted by Chris Hostetter <ho...@fucit.org>.
On Tue, 28 Sep 2021, Timothy Potter wrote:
: Date: Tue, 28 Sep 2021 14:32:33 -0600
: From: Timothy Potter <th...@apache.org>
: Reply-To: dev@solr.apache.org
: To: Solr Dev <de...@solr.apache.org>
: Subject: 8.10 docker image please
:
: can someone who has done this before please publish the 8.10 Docker
: image now that the release is done
I (fixed and) ran the update script, and ran the scripted tests on the
resulting image, PR online...
https://github.com/docker-solr/docker-solr/pull/387
...some one with docker-solr karma has to take the last few inches over
the finish line.
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org