You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by bjchambers <gi...@git.apache.org> on 2016/12/16 01:50:22 UTC

[GitHub] incubator-beam pull request #1638: Make a RunnableOnService test for Metrics

GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/1638

    Make a RunnableOnService test for Metrics

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam ros-metrics-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1638
    
----
commit 6f57c0bda89b49576a09d2babe386632522b8544
Author: bchambers <bc...@google.com>
Date:   2016-12-16T01:04:59Z

    Add UsesMetrics interface and exclude from runners

commit 850af9c5e2566e1127ab8e5c0e2f1b50e3cc404e
Author: bchambers <bc...@google.com>
Date:   2016-12-16T01:04:21Z

    Add Serializability as needed for Metrics

commit 960f931b6e1893b85feda157e11b354480f9e62b
Author: bchambers <bc...@google.com>
Date:   2016-12-16T01:05:16Z

    Add runnable on service test for Metrics

commit 4d698cec4b8353d1e7cdc6bcc6b762d59874035e
Author: bchambers <bc...@google.com>
Date:   2016-12-16T01:48:23Z

    fixup! Remove test from DirectRunnerTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1638: Make a RunnableOnService test for Metrics

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---