You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/01 00:10:22 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1406: SAMZA-2561: Add config map to MetricsHeader

rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463893096



##########
File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java
##########
@@ -60,6 +62,7 @@
   private static final String CONTAINER_THREAD_POOL_SIZE_METRIC_NAME = "containerThreadPoolSize";
   private static final String CONTAINER_MODELS_METRIC_NAME = "containerModels";
   private static final String AUTOSIZING_ENABLED_METRIC_NAME = "autosizingEnabled";
+  private static final String CONFIG = "config";

Review comment:
       Nit: CONFIG_METRICGROUP_NAME




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org