[GitHub] [spark] srowen commented on a change in pull request #32261: [SPARK-35151][BUILD] Add compile arg to suppress `symbol literal is deprecated` compilation warnings in Scala 2.13

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #32261:
URL: https://github.com/apache/spark/pull/32261#discussion_r623065202



##########
File path: pom.xml
##########
@@ -3369,6 +3369,7 @@
                   <arg>-Wconf:msg=Auto-application to \`\(\)\` is deprecated:s</arg>
                   <arg>-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s</arg>
                   <arg>-Wconf:msg=method without a parameter list overrides a method with a single empty one:s</arg>
+                  <arg>-Wconf:msg=symbol literal is deprecated:s</arg>

Review comment:
       Wait, I'm still not clear why we can't replace `'foo` with `Symbol(foo)`. That does not remove usage of Symbol. It just removes usage of the deprecated literal syntax. I thought the resolution was that this much was fine? the other issue is kind of conflating the deprecated syntax and Symbol itself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org