You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Fengling Wang (Code Review)" <ge...@cloudera.org> on 2018/06/15 20:11:16 UTC
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10734
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
KUDU-2314 Fix printing empty wal & metadata dirs
Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 19 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10734/1
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 5:
yes, makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 20 Jun 2018 18:16:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc@1012
PS3, Line 1012: ASSERT_STR_CONTAINS(report_str, "wal directory: " + opts.wal_root);
> Ah oops, you can revert the std::move().
yup.
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 18 Jun 2018 22:28:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Looks good, just a few nits
http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1003
PS2, Line 1003: fs::FsReport report;
nit: maybe move this down by L1009 or 1010 where we actually use it?
http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1007
PS2, Line 1007: asdf
nit: maybe "metadata" for consistency? :)
http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1008
PS2, Line 1008: opts
nit: std::move(opts)
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 18 Jun 2018 21:54:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 5: Code-Review+1
FWIW, I think it would have also been fine to change BlockManager::Open such that the report is no longer overwritten but just updated instead.
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 20 Jun 2018 17:21:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10734
to look at the new patch set (#2).
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
KUDU-2314 Fix printing empty wal & metadata dirs
Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10734/2
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1002
PS1, Line 1002: TestOpenReport
> Perhaps TestAncillaryDirsReported or something?
Good.
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1011
PS1, Line 1011: "metadata directory: " + wal_path
> How about a test that uses a separate WAL and metadata directory? That way
Makes sense. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 18 Jun 2018 20:16:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10734
to look at the new patch set (#3).
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
KUDU-2314 Fix printing empty wal & metadata dirs
Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10734/3
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 18 Jun 2018 22:34:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 1: Verified+1
(2 comments)
Test failure seems unrelated
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1002
PS1, Line 1002: TestOpenReport
> hmm..maybe this is not a descrptive name?
Perhaps TestAncillaryDirsReported or something?
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1011
PS1, Line 1011: "metadata directory: " + wal_path
How about a test that uses a separate WAL and metadata directory? That way this wouldn't break if this default behavior ever changes.
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 18 Jun 2018 17:07:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10734
to look at the new patch set (#4).
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
KUDU-2314 Fix printing empty wal & metadata dirs
Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10734/4
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 2:
Done. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 18 Jun 2018 22:02:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Fengling Wang (Code Review)" <ge...@cloudera.org>.
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1002
PS1, Line 1002: TestOpenReport
hmm..maybe this is not a descrptive name?
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 15 Jun 2018 20:14:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:
http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc@1012
PS3, Line 1012: ASSERT_STR_CONTAINS(report_str, "wal directory: " + opts.wal_root);
> warning: 'opts' used after it was moved [bugprone-use-after-move]
Ah oops, you can revert the std::move().
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 18 Jun 2018 22:24:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2314 Fix printing empty wal & metadata dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs
......................................................................
KUDU-2314 Fix printing empty wal & metadata dirs
Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Reviewed-on: http://gerrit.cloudera.org:8080/10734
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot