You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/05/25 16:26:11 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #35767: GH-34784: [Go] Fix 32-bit build
zeroshade opened a new pull request, #35767:
URL: https://github.com/apache/arrow/pull/35767
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Two locations in the code cause issues when building with `GOARCH=386` (e.g. 32-bit systems).
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
In the `compute` package we assume a 64-bit system when using an untyped `int` to hold `math.MaxInt64` which overflows on a 32-bit system. So we just explicitly identify it as an `int64`
In the `cdata` package we use the older `*(*[maxlen]*C.void)(unsafe.Pointer(.....))[:]` syntax to retrieve the `void**` for the buffers, with maxlen set to a very large constant. Unfortunately on a 32-bit system this is larger than the address space. Instead we switch to using the `unsafe.Slice` method that was added in go1.17.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563584302
> @raulcd @assignUser would it be okay to get this into the v12.0.1 patch release?
This seems to be an atomic change with no links to other commits and it fixes an important issue for 32bit users so +1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563188154
:warning: GitHub issue #34784 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35767:
URL: https://github.com/apache/arrow/pull/35767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1570016285
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/df5d3d74fc2f4e6c9d2be58ebbe8462a...dbe7ec4758134b2a891b0a3e2c23c88b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563188107
* Closes: #34784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1569317221
Benchmark runs are scheduled for baseline = 77a71305090fcebcc87fa5b8c7dba1398cef9f68 and contender = 9eaee2a532ef3f13de7f0448d6c61a02b33730ea. 9eaee2a532ef3f13de7f0448d6c61a02b33730ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28b58fa1b3f74d3eb67cbda8a9f2fe34...5d7248b5f5e443eab024fbd13c885dea/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9c1cae39d1b64a8980633c8c53da39b0...71b449ce2f2042deae5b37fa587b3882/)
[Failed :arrow_down:9.14% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/df5d3d74fc2f4e6c9d2be58ebbe8462a...dbe7ec4758134b2a891b0a3e2c23c88b/)
[Failed :arrow_down:1.12% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6f02474150094a1c949e54e5b4d644de...d328c22dee9e4a54b623903116a47796/)
Buildkite builds:
[Finished] [`9eaee2a5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2938)
[Finished] [`9eaee2a5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2974)
[Finished] [`9eaee2a5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2939)
[Finished] [`9eaee2a5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2964)
[Finished] [`77a71305` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2937)
[Failed] [`77a71305` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2973)
[Failed] [`77a71305` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2938)
[Failed] [`77a71305` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2963)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563375651
Yup - I don't think we need to change everything immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563188142
@raulcd @assignUser would it be okay to get this into the v12.0.1 patch release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1563371552
@lidavidm only in the spots where it's possible we might be dealing with values that will actually go near the overflow/underflow boundaries. I think it's fine to play wack-a-mole with them when users find issues for now as it doesn't come up often and as long as new code is developed properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35767: GH-34784: [Go] Fix 32-bit build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35767:
URL: https://github.com/apache/arrow/pull/35767#issuecomment-1564581565
Thanks @assignUser I'll merge this and have it marked as milestone 12.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org