You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org> on 2023/06/06 10:04:31 UTC
[GitHub] [kafka] Vaibhav-Nazare opened a new pull request, #13817: KAFKA-15062: Adding ppc64le build stage
Vaibhav-Nazare opened a new pull request, #13817:
URL: https://github.com/apache/kafka/pull/13817
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1579948195
@dajac Can you check the please check the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392307654
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ steps {
+ doValidation()
+ doTest(env, 'unitTest')
Review Comment:
Corrected to `doTest(env)`, missed to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1740308135
Hi @divijvaidya @mimaison @cmccabe any updates on how we want to proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1610089621
Hey @Vaibhav-Nazare
A KIP needs at least 3 committer votes and I believe we haven't heard from other folks in the community on the KIP. I am waiting for others to chime in. Otherwise, we can start a vote in 2 weeks (and hope that the KIP gets at least 3 votes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1815159323
Hi @mimaison I ran the `kafka.zk.ZkMigrationIntegrationTest` locally and all the related tests are passing.
```
./gradlew -PscalaVersion=2.13.12 core:test --tests kafka.zk.ZkMigrationIntegrationTest --profile --continue -PkeepAliveMode="session"
-PtestLoggingEvents=started,passed,skipped,failed -PignoreFailures=true -PmaxParallelForks=2 -PmaxTestRetries=1 -PmaxTestRetryFailures=10
Starting a Gradle Daemon, 1 busy Daemon could not be reused, use --status for details
> Configure project :
Starting build with version 3.7.0-SNAPSHOT (commit id e7f4f5df) using Gradle 8.3, Java 21 and Scala 2.13.12
Build properties: maxParallelForks=2, maxScalacThreads=8, maxTestRetries=1
> Task :storage:storage-api:processResources NO-SOURCE
> Task :server-common:processResources NO-SOURCE
> Task :storage:storage-api:processTestResources NO-SOURCE
> Task :group-coordinator:processResources UP-TO-DATE
> Task :raft:processResources UP-TO-DATE
> Task :metadata:processResources UP-TO-DATE
> Task :core:processResources UP-TO-DATE
> Task :server-common:processTestResources UP-TO-DATE
> Task :server-common:createVersionFile UP-TO-DATE
> Task :group-coordinator:processTestResources UP-TO-DATE
> Task :metadata:processTestResources UP-TO-DATE
> Task :core:processTestResources UP-TO-DATE
> Task :tools:tools-api:processResources NO-SOURCE
> Task :storage:storage-api:createVersionFile UP-TO-DATE
> Task :storage:processResources UP-TO-DATE
> Task :raft:processTestResources UP-TO-DATE
> Task :tools:tools-api:createVersionFile UP-TO-DATE
> Task :storage:createVersionFile UP-TO-DATE
> Task :raft:createVersionFile UP-TO-DATE
> Task :clients:processResources UP-TO-DATE
> Task :clients:createVersionFile UP-TO-DATE
> Task :generator:compileJava UP-TO-DATE
> Task :generator:processResources NO-SOURCE
> Task :generator:classes UP-TO-DATE
> Task :clients:processTestResources UP-TO-DATE
> Task :generator:jar UP-TO-DATE
> Task :core:processMessages UP-TO-DATE
> Task :group-coordinator:processMessages UP-TO-DATE
> Task :metadata:processMessages UP-TO-DATE
> Task :raft:processMessages UP-TO-DATE
> Task :storage:processMessages UP-TO-DATE
> Task :clients:processMessages UP-TO-DATE
> Task :clients:compileJava UP-TO-DATE
> Task :clients:classes UP-TO-DATE
> Task :clients:processTestMessages UP-TO-DATE
> Task :tools:tools-api:compileJava UP-TO-DATE
> Task :tools:tools-api:classes UP-TO-DATE
> Task :tools:tools-api:jar UP-TO-DATE
> Task :server-common:compileJava UP-TO-DATE
> Task :server-common:classes UP-TO-DATE
> Task :server-common:jar UP-TO-DATE
> Task :storage:storage-api:compileJava UP-TO-DATE
> Task :storage:storage-api:classes UP-TO-DATE
> Task :raft:compileJava UP-TO-DATE
> Task :storage:storage-api:jar UP-TO-DATE
> Task :raft:classes UP-TO-DATE
> Task :raft:jar UP-TO-DATE
> Task :storage:compileJava UP-TO-DATE
> Task :storage:classes UP-TO-DATE
> Task :storage:jar UP-TO-DATE
> Task :metadata:compileJava UP-TO-DATE
> Task :metadata:classes UP-TO-DATE
> Task :metadata:jar UP-TO-DATE
> Task :clients:compileTestJava UP-TO-DATE
> Task :group-coordinator:compileJava UP-TO-DATE
> Task :group-coordinator:classes UP-TO-DATE
> Task :core:compileJava NO-SOURCE
> Task :group-coordinator:jar UP-TO-DATE
> Task :clients:shadowJar UP-TO-DATE
> Task :clients:jar SKIPPED
> Task :clients:testClasses UP-TO-DATE
> Task :storage:storage-api:compileTestJava UP-TO-DATE
> Task :storage:storage-api:testClasses UP-TO-DATE
> Task :server-common:compileTestJava UP-TO-DATE
> Task :server-common:testClasses UP-TO-DATE
> Task :raft:compileTestJava UP-TO-DATE
> Task :raft:testClasses UP-TO-DATE
> Task :group-coordinator:compileTestJava UP-TO-DATE
> Task :group-coordinator:testClasses UP-TO-DATE
> Task :metadata:compileTestJava UP-TO-DATE
> Task :metadata:testClasses UP-TO-DATE
> Task :core:compileScala UP-TO-DATE
> Task :core:classes UP-TO-DATE
> Task :core:checkstyleMain UP-TO-DATE
> Task :core:compileTestJava NO-SOURCE
> Task :core:compileTestScala UP-TO-DATE
> Task :core:testClasses UP-TO-DATE
> Task :core:checkstyleTest UP-TO-DATE
> Task :core:spotbugsMain UP-TO-DATE
> Task :core:test
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [1] Type=ZK, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [1] Type=ZK, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [2] Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [2] Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [4] Type=ZK, MetadataVersion=3.7-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [4] Type=ZK, MetadataVersion=3.7-IV0, Security=PLAINTEXT SKIPPED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [5] Type=ZK, MetadataVersion=3.7-IV1, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateTopicDeletions(ClusterInstance) > [5] Type=ZK, MetadataVersion=3.7-IV1, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWriteScram(ClusterInstance) > [1] Type=ZK, Name=testDualWriteScram, MetadataVersion=3.5-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWriteScram(ClusterInstance) > [1] Type=ZK, Name=testDualWriteScram, MetadataVersion=3.5-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testNewAndChangedTopicsInDualWrite(ClusterInstance) > [1] Type=ZK, Name=testNewAndChangedTopicsInDualWrite, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testNewAndChangedTopicsInDualWrite(ClusterInstance) > [1] Type=ZK, Name=testNewAndChangedTopicsInDualWrite, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWriteQuotaAndScram(ClusterInstance) > [1] Type=ZK, Name=testDualWriteQuotaAndScram, MetadataVersion=3.5-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWriteQuotaAndScram(ClusterInstance) > [1] Type=ZK, Name=testDualWriteQuotaAndScram, MetadataVersion=3.5-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrate(ClusterInstance) > [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrate(ClusterInstance) > [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateAcls(ClusterInstance) > [1] Type=ZK, Name=testMigrateAcls, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testMigrateAcls(ClusterInstance) > [1] Type=ZK, Name=testMigrateAcls, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testStartZkBrokerWithAuthorizer(ClusterInstance) > [1] Type=ZK, Name=testStartZkBrokerWithAuthorizer, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testStartZkBrokerWithAuthorizer(ClusterInstance) > [1] Type=ZK, Name=testStartZkBrokerWithAuthorizer, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [1] Type=ZK, MetadataVersion=3.4-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [1] Type=ZK, MetadataVersion=3.4-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [2] Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [2] Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [4] Type=ZK, MetadataVersion=3.7-IV0, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [4] Type=ZK, MetadataVersion=3.7-IV0, Security=PLAINTEXT PASSED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [5] Type=ZK, MetadataVersion=3.7-IV1, Security=PLAINTEXT STARTED
Gradle Test Run :core:test > Gradle Test Executor 1 > ZkMigrationIntegrationTest > testDualWrite(ClusterInstance) > [5] Type=ZK, MetadataVersion=3.7-IV1, Security=PLAINTEXT PASSED
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 2m
55 actionable tasks: 1 executed, 54 up-to-date
See the profiling report at: file:///home/ubuntu/kafka/build/reports/profile/profile-2023-11-16-19-03-58.html
A fine-grained performance profile is available: use the --scan option.
```
Figured out the exact cause for failures, so the shared power nodes doesn't have Scala installed. Will raise a JIRA ticket and get SCALA 2.13.12 installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1759053190
Hi @mimaison I have updated the stage for PowerPC as of now, for the Java Version upgrade I need to figure out how to do it, may be we can have it in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2010007861
I don't think (at least don't know how) we can modify the jobs in Jenkins directly. The jobs are automatically created via the Jenkinsfile in this repository. I see some other Apache projects have multiple Jenkinsjob files, it would be good to understand how it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1628235284
@divijvaidya Can we begin with voting for the KIP, if yes let me know how it is to be done, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1685572794
Hi @mimaison @cmccabe If you agree can we have your votes too on the KIP please, @divijvaidya has already voted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1481254113
##########
Jenkinsfile:
##########
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ when {
Review Comment:
I was asking as I don't know either. But it does not seem to work: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14717/7/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1983520711
Thanks @mimaison for looking into at, so seems we are out of options to build the specific stage daily, what if we add an additional jenkins file just to build for ppc64le something like Jenkinsfile.ppc64le in that way we can have the cron job which you mentioned previously would work just some thoughts from my end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2014393617
Yes I would have followed the same , I have started a discussing on dev list.
https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1580397394
Hi @Vaibhav-Nazare
It was intentionally disabled in the past since the infrastructure was flaky https://github.com/apache/kafka/pull/12380
If we want to officially test and support this platform, I would suggest that you start a KIP similar to https://cwiki.apache.org/confluence/display/KAFKA/KIP-826%3A+Define+platforms+supported and initiate a discussion in the community about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1807746432
Rerunning the build: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14717/2/pipeline/14/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1807487012
Hi @mimaison Can we rerun the job now, jdk_21_latest has been installed on the shared power nodes by ASF infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392309926
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
Review Comment:
As per my knowledge the job must be configured in Jenkins Job to run nightly, correct me if wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1877357358
Sorry for the delay. I tried to build this but it fails in the CI with the following error:
```
WorkflowScript: 91: unexpected token: % @ line 91, column 82.
InMillis() / 1000 / 60 / 60 / % 24
```
See https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14717/6/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1474755853
##########
Jenkinsfile:
##########
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ when {
Review Comment:
Not sure how to use `cron` for a specific stage. Maybe can you help out on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1580457270
Hi @divijvaidya
Thanks for the information, will start a KIP.
Also FYI new power VMs are created/managed by ASF infra and much more stable
https://issues.apache.org/jira/browse/INFRA-24663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1596569792
Hi @divijvaidya
I have created the KIP https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Add+Power%28ppc64le%29+support
Please let us know the further path forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1596959362
HI @divijvaidya Thanks for the information , I have created a discussion thread for the KIP as per given process
https://lists.apache.org/thread/y62m18k5bgsbcmkw2f80vwnj2vjgy7nz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1815173826
JIRA ticket for Scala Installation on shared power nodes: https://issues.apache.org/jira/browse/INFRA-25163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392309926
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
Review Comment:
As per my knowledge the job must be configured in Jenkins Job to run nightly, correct me if wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1917302430
Hi @mimaison the above error was fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1971535782
@mimaison any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1643386529
Hi @cmccabe @mimaison @divijvaidya Any further updates on nightly job enablement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1729435287
Hi Team, can we look into this PR as the KIP-942 has been adopted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1833413348
Hi @mimaison any updates on the latest changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1869973402
Hi Team , any updates on the plan to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1490885160
##########
Jenkinsfile:
##########
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ when {
Review Comment:
@mimaison I have reverted the change, seem the previous logic one which I implemented is the only way to do it from my pov.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012341540
Instead of directly asking Infra, I think asking on the dev list first might have been better as suggested above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2034128217
@divijvaidya can you also have a look at this once https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1596862610
Hey @Vaibhav-Nazare
The next step us to start a [DISCUSS] thread in the mailing list where the community can have a discussion on the KIP. The process of starting a KIP is mentioned here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1603698336
Hi @divijvaidya any further updates for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392208754
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
Review Comment:
The KIP states that this build will run nightly. Can you clarify which part of this stage does the scheduling?
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ steps {
+ doValidation()
+ doTest(env, 'unitTest')
Review Comment:
The KIP does not state that only `unitTest` would run. Why are we doing setting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1474685305
##########
Jenkinsfile:
##########
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ when {
Review Comment:
Can you clarify why we are not using the `cron` statement? For example https://github.com/apache/zookeeper/blob/master/Jenkinsfile#L31-L33
##########
Jenkinsfile:
##########
@@ -1,3 +1,7 @@
+
+
+
+
Review Comment:
Can we undo this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1755428479
Hi @mimaison, thanks for the reply.
We were referring to older Jenkins file before the support was disabled on Power, No specific reason to use nested stage fields.
If any modification is required, would do it according to accepted and correct ways, please do let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1983537805
Yeah that seems like the next best approach. However I have no idea how to set that up. If you know how to set that up, go ahead and update the PR otherwise you'll probably will have to ask on the dev mailing list to see if anyone is familiar with this type of setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757770296
Yes it would be better if the Java version can be specified as a config. It's something you need to figure out.
The job will be automatically created when we commit the updated Jenkinsfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1752766226
Thanks @Vaibhav-Nazare for the KP and PR.
I've not looked at Jenkinsfiles in a while, can you clarify why you used nested `stage` fields unlike the other existing platforms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1643452195
@Vaibhav-Nazare The KIP needs to be voted. So far you've only started a discussion. I'd recommend replying to the discussion thread to ask for any more feedback, otherwise you can start a vote in the next few days. See xhttps://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for the process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757278411
Then I'd probably make the new ppc job copy the existing jobs and use a single `stage`.
Another question: What will be the process of updating the Java version? Can this be part of the config or will we also need to contact the Apache Infra team?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012071722
I have created a JIRA to have the new job configured https://issues.apache.org/jira/browse/INFRA-25631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012193438
@mimaison can you have a loot at it once at the JIRA mentioned in previous comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392404934
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
Review Comment:
I have updated the code to run nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392307654
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ steps {
+ doValidation()
+ doTest(env, 'unitTest')
Review Comment:
Corrected to `doTest(env)`, missed to remove `unitTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1474754259
##########
Jenkinsfile:
##########
@@ -1,3 +1,7 @@
+
+
+
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2090390142
Hi @mimaison seems no discussion happening on the mailing list, Just a query as per the reply on the jira issue which I raised as per the comment a committer has access to enable job any time , so may be can you look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802230356
Thanks for the updates! Can we switch to jdk_21_latest? as it's the newest java version we use in the other stages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802275265
So obvious reasons, changes in Jenkinsfile are only tested if the PR is from a committer. So I opened https://github.com/apache/kafka/pull/14717 to run your changes.
You can see the Power build failed immediately with:
```
ERROR: JAVA_HOME is set to an invalid directory: /home/jenkins/tools/java/latest21
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802353727
Raised a JIRA ticket to have jdk_21_latest installed on shared power nodes
https://issues.apache.org/jira/browse/INFRA-25149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1392404934
##########
Jenkinsfile:
##########
@@ -174,6 +174,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
Review Comment:
I have updated the code to run nightly in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757493253
@mimaison As my point of view for Java version , may be we can have this part of config itself so we don't have to raise tickets frequently to ASF team, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1637117372
Hi @divijvaidya Any further updates on nightly job enablement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1474755853
##########
Jenkinsfile:
##########
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+ stage('PowerPC') {
+ agent { label 'ppc64le' }
+ tools {
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ when {
Review Comment:
Was not aware if we can use `cron `for a specific stage. Have updated the code hope it works out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "Vaibhav-Nazare (via GitHub)" <gi...@apache.org>.
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2003833677
Hi @mimaison additional jenkinsfile for ppc64le has been added , also as per my understanding some changes would be required at https://ci-builds.apache.org/job/Kafka/job/kafka/ to have a new job configured for ppc64le
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1983268003
Sorry for the delay. I tried building your branch and it fails with:
```
Scripts not permitted to use method org.jenkinsci.plugins.workflow.support.steps.build.RunWrapper getRawBuild
```
See https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14717/8/pipeline/14
I tried a few things to fix the expression in [my branch](https://github.com/mimaison/kafka/commits/test-powerpc/). It seems I'm getting close to run but I'm not sure it will do what we want. Reading the [docs for `when`](https://www.jenkins.io/doc/book/pipeline/syntax/#when) if seems to simply be a condition for the build to run, not a trigger. So if I understand correctly with the current change the PowerPC stage would run on any PRs opened/updated between 10am-11am. This is different than building trunk daily at 10am.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org