You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/16 07:26:09 UTC

[GitHub] [incubator-tvm] hlu1 commented on issue #4723: [Relay] Port relay.backend.build to c++

hlu1 commented on issue #4723: [Relay] Port relay.backend.build to c++
URL: https://github.com/apache/incubator-tvm/pull/4723#issuecomment-575019899
 
 
   Sorry I missed a few things at the beginning and just added them.
   
   Do you mean translating this part line by line, https://github.com/apache/incubator-tvm/blob/master/python/tvm/build_module.py#L509-L650?
   
   Some of the type checks are not needed in C++, and the signature of https://github.com/apache/incubator-tvm/blob/bfb4884e47f7d2c759b2ee707aa18acf35116380/python/tvm/relay/backend/_backend.py#L65-L88 is a lot simpler.
   
   Also, 
   https://github.com/apache/incubator-tvm/blob/master/python/tvm/build_module.py#L635-L650 has been implemented in here https://github.com/apache/incubator-tvm/blob/master/src/codegen/build_module.cc#L278-L319. All I need to do is call this function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services