[GitHub] [sling-org-apache-sling-testing-rules] enapps-enorman commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent

[GitBox <gi...@apache.org>]

enapps-enorman commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1324328375

   I don't have any specific concerns with this solution.  I'd just point out that this solution would be only for consumers who are still using junit4.
   
   For those that have migrated to junit5, a [BeforeEachCallback](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeEachCallback.html) extension would be needed instead of this new rule.
   
   However, making a fork of the sling-org-apache-sling-testing-rules project that is compatible with junit5 is a larger problem and should probably be considered separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org