[jira] [Commented] (BEAM-3450) RemoteGrpcPorts should contain the wire format

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321299#comment-16321299 ] 

ASF GitHub Bot commented on BEAM-3450:
--------------------------------------

tgroh opened a new pull request #4386: [BEAM-3450] Add wire_coder_id to RemoteGrpcPort
URL: https://github.com/apache/beam/pull/4386
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   This is the first step to decouple the wire-format coders from intermediate PCollection coders
   
   Fallback to the coder of the output PCollection if this field is not populated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RemoteGrpcPorts should contain the wire format
> ----------------------------------------------
>
>                 Key: BEAM-3450
>                 URL: https://issues.apache.org/jira/browse/BEAM-3450
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model, runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This forces the runner to include the wire format independently from a PCollection coder, which should be the coder of the type of the PCollection (e.g. in Java, PCollection<T> has Coder<T> instead of Coder<WindowedValue<T>>, but the runner must use Coder<WindowedValue<T>> over edges).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)