You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/08/18 04:21:05 UTC
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24705
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
[thirdparty] skip building unused LLVM/CLANG tools
This changelist removes a few more LLVM/CLANG tools from the list
of components to build: those aren't used in Kudu. Removing unused
tools helps reduce build times and the size of the pre-built archive.
Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/24705/1
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:13:32 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh@357
PS1, Line 357: LLVM_PATCHLEVEL=11
nit: Is this to trigger a rebuild? If it is already built, there is no harm in keeping the old build until something else triggers a rebuild.
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Aug 2026 09:46:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
[thirdparty] skip building unused LLVM/CLANG tools
This changelist removes a few more LLVM/CLANG tools from the list
of components to build: those aren't used in Kudu. Removing unused
tools helps reduce build times and the size of the pre-built archive.
Below are the stats on the pre-built archive size reduction for a
couple of supported platforms:
llvm-11.0.0.p10.rhel-9.x86_64.gcc-11.5.tar.xz 333668880
llvm-11.0.0.p11.rhel-9.x86_64.gcc-11.5.tar.xz 283293488
llvm-11.0.0.p10.macos-26.x86_64.clang-17.0.tar.xz 237209484
llvm-11.0.0.p11.macos-26.x86_64.clang-17.0.tar.xz 198899528
Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Reviewed-on: http://gerrit.cloudera.org:8080/24705
Reviewed-by: Ashwani Raina <ar...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Ashwani Raina: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Martonka, Ashwani Raina, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24705
to look at the new patch set (#2).
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
[thirdparty] skip building unused LLVM/CLANG tools
This changelist removes a few more LLVM/CLANG tools from the list
of components to build: those aren't used in Kudu. Removing unused
tools helps reduce build times and the size of the pre-built archive.
Below are the stats on the pre-built archive size reduction for a
couple of supported platforms:
llvm-11.0.0.p10.rhel-9.x86_64.gcc-11.5.tar.xz 333668880
llvm-11.0.0.p11.rhel-9.x86_64.gcc-11.5.tar.xz 283293488
llvm-11.0.0.p10.macos-26.x86_64.clang-17.0.tar.xz 237209484
llvm-11.0.0.p11.macos-26.x86_64.clang-17.0.tar.xz 198899528
Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/24705/2
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2026 13:07:22 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@7
PS1, Line 7: skip building unused LLVM/CLANG tools
just curious: How did you figure out what LLVM/CLANG tools are unused in Kudu?
There are some other tools inside 'thirdparty/src/llvm-11.0.0.src/tools/' that don't seem to be applicable to Kudu, e.g., llvm-microsoft-demangle-fuzzer, msbuild, etc.
Should those also be skipped?
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@11
PS1, Line 11: reduce build times
It would be great if you could also add some build metrics showcasing reduction in build times. A one-liner stating the same is also fine.
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Aug 2026 12:00:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] skip building unused LLVM/CLANG tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@7
PS1, Line 7: skip building unused LLVM/CLANG tools
Because those are in the 'extra' subdir: those tools aren't invoked by LLVM/CLANG toolchain on its own, but they are stand-alone tools. From the extra tools, we only use iwyu. Building many of them was already turned off (that's why the long list), these are just extra that probably appeared in newer LLVM versions (since LLVM 4.0) but were not put into the list.
> There are some other tools inside 'thirdparty/src/llvm-11.0.0.src/tools/' that don't seem to be applicable to Kudu, e.g., llvm-microsoft-demangle-fuzzer, msbuild, etc.
>
> Should those also be skipped?
Those aren't built already. As for the list of the LLVM tools that are build now, most of them can be used by the LLVM/CLANG toolchain internally during build and codegeneration, and I didn't have a chance to focus on clarifying which exactly are invoked during Kudu build or codegen. Feel free to clarify on this if you have a chance: it's always OK to post a follow-up update to remove more unused tools.
http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@11
PS1, Line 11: reduce build times
> It would be great if you could also add some build metrics showcasing redu
I posted stats on the archive size reduction. As for the build times, I'm not sure it's worth it to recompile LLVM just to produce those stats: by default we now use pre-built artifacts/archives, and it's certainly less time compiling with this patch than before.
http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh@357
PS1, Line 357: LLVM_PATCHLEVEL=11
> nit: Is this to trigger a rebuild? If it is already built, there is no harm
No, this isn't for triggering a rebuild. This is for properly naming pre-built archives and differentiating between them.
--
To view, visit http://gerrit.cloudera.org:8080/24705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Aug 2026 14:56:54 +0000
Gerrit-HasComments: Yes