You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Saman Alvi <sa...@pivotal.io> on 2014/10/14 16:37:20 UTC
Review Request 26686: Metrics graph displayed on service pages should
be defined in configuration files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26686/
-----------------------------------------------------------
Review request for Ambari.
Description
-------
Currently, which metrics graphs to display in Ambari Web's service pages is hardcoded in ambari-web code.
We should make it such that the graphs to display are declared in the stack definition for each service.
Diffs
-----
Diff: https://reviews.apache.org/r/26686/diff/
Testing
-------
File Attachments
----------------
patch file
https://reviews.apache.org/media/uploaded/files/2014/10/14/595ecc89-3e53-4a94-9565-dd424c4d1987__AMBARI-7601.patch
Thanks,
Saman Alvi
Re: Review Request 26686: Metrics graph displayed on service pages
should be defined in configuration files
Posted by Grace Li <gl...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26686/#review56529
-----------------------------------------------------------
Ship it!
Ship It!
- Grace Li
On Oct. 14, 2014, 2:37 p.m., Saman Alvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26686/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 2:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Description
> -------
>
> Currently, which metrics graphs to display in Ambari Web's service pages is hardcoded in ambari-web code.
> We should make it such that the graphs to display are declared in the stack definition for each service.
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/26686/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2014/10/14/595ecc89-3e53-4a94-9565-dd424c4d1987__AMBARI-7601.patch
>
>
> Thanks,
>
> Saman Alvi
>
>
Re: Review Request 26686: Metrics graph displayed on service pages
should be defined in configuration files
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26686/#review56877
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 14, 2014, 2:37 p.m., Saman Alvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26686/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 2:37 p.m.)
>
>
> Review request for Ambari.
>
>
> Description
> -------
>
> Currently, which metrics graphs to display in Ambari Web's service pages is hardcoded in ambari-web code.
> We should make it such that the graphs to display are declared in the stack definition for each service.
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/26686/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2014/10/14/595ecc89-3e53-4a94-9565-dd424c4d1987__AMBARI-7601.patch
>
>
> Thanks,
>
> Saman Alvi
>
>