You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/10/17 07:43:03 UTC
[GitHub] [hive] szlta commented on a diff in pull request #3667: HIVE-26556: ADDENDUM: Iceberg: Properties set in HiveIcebergSerde are not propagated to jobconf.
szlta commented on code in PR #3667:
URL: https://github.com/apache/hive/pull/3667#discussion_r996710899
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##########
@@ -137,6 +137,8 @@ public void initialize(@Nullable Configuration configuration, Properties serDePr
// Currently ClusteredWriter is used which requires that records are ordered by partition keys.
// Here we ensure that SortedDynPartitionOptimizer will kick in and do the sorting.
// TODO: remove once we have both Fanout and ClusteredWriter available: HIVE-25948
+ HiveConf.setIntVar(configuration, HiveConf.ConfVars.HIVEOPTSORTDYNAMICPARTITIONTHRESHOLD, 1);
+ HiveConf.setVar(configuration, HiveConf.ConfVars.DYNAMICPARTITIONINGMODE, "nonstrict");
jobConf.put(HiveConf.ConfVars.HIVEOPTSORTDYNAMICPARTITIONTHRESHOLD.varname, "1");
jobConf.put(HiveConf.ConfVars.DYNAMICPARTITIONINGMODE.varname, "nonstrict");
Review Comment:
Do we need to keep the `jobConf.put` invocations here besides `HiveConf.set` calls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org