You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/01 13:04:07 UTC
[GitHub] [tvm] NicolaLancellotti opened a new pull request, #12255: [PyTorch] Disable failing tests on AArch64
NicolaLancellotti opened a new pull request, #12255:
URL: https://github.com/apache/tvm/pull/12255
This pr disables PyTorch tests that fail on AArch64.
We need this pr because we want to enable PyTorch tests on AArch64.
A future pr will fix the failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12255: [PyTorch] Disable failing tests on AArch64
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12255:
URL: https://github.com/apache/tvm/pull/12255#discussion_r934796656
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -4060,6 +4061,10 @@ def test_forward_pretrained_bert_base_uncased():
print("TVM top-1 id: {}, token: {}".format(tvm_pred_idx, tvm_pred_token))
+@pytest.mark.skipif(
+ platform.machine() == "aarch64",
+ reason="Currently failing on AArch64",
Review Comment:
Can you file a GitHub issue with the context on the skip and link it here? also just fyi I think we can merge all the skip test PRs since they have a similar theme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a diff in pull request #12255: [PyTorch] Disable failing tests on AArch64
Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #12255:
URL: https://github.com/apache/tvm/pull/12255#discussion_r935226698
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -4060,6 +4061,10 @@ def test_forward_pretrained_bert_base_uncased():
print("TVM top-1 id: {}, token: {}".format(tvm_pred_idx, tvm_pred_token))
+@pytest.mark.skipif(
+ platform.machine() == "aarch64",
+ reason="Currently failing on AArch64",
Review Comment:
Sure, we'll raise a tracking issue to investigate the fix for all tests being skipped in these PRs, namely this one, #12257, #12256.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #12255: [PyTorch] Disable failing tests on AArch64
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #12255:
URL: https://github.com/apache/tvm/pull/12255#issuecomment-1202230441
I raised an issue #12276 as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #12255: [PyTorch] Disable failing tests on AArch64
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #12255:
URL: https://github.com/apache/tvm/pull/12255#issuecomment-1201174839
@leandron @ashutosh-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #12255: [PyTorch] Disable failing tests on AArch64
Posted by GitBox <gi...@apache.org>.
leandron merged PR #12255:
URL: https://github.com/apache/tvm/pull/12255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org