You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2025/06/14 10:44:17 UTC
(maven-wagon) 01/01: @Ignore doesn't work in a JUnit 3 test
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch ignore2
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit 7bf7a9bd1d36753d9afa541f40c7efee89b20e7b
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Sat Jun 14 06:44:09 2025 -0400
@Ignore doesn't work in a JUnit 3 test
---
.../providers/webdav/HttpClientWagonTest.java | 41 ----------------------
1 file changed, 41 deletions(-)
diff --git a/wagon-providers/wagon-webdav-jackrabbit/src/test/java/org/apache/maven/wagon/providers/webdav/HttpClientWagonTest.java b/wagon-providers/wagon-webdav-jackrabbit/src/test/java/org/apache/maven/wagon/providers/webdav/HttpClientWagonTest.java
index efea8983..1a23dabb 100644
--- a/wagon-providers/wagon-webdav-jackrabbit/src/test/java/org/apache/maven/wagon/providers/webdav/HttpClientWagonTest.java
+++ b/wagon-providers/wagon-webdav-jackrabbit/src/test/java/org/apache/maven/wagon/providers/webdav/HttpClientWagonTest.java
@@ -31,11 +31,9 @@
import org.apache.maven.wagon.repository.Repository;
import org.apache.maven.wagon.shared.http.HttpConfiguration;
import org.apache.maven.wagon.shared.http.HttpMethodConfiguration;
-import org.junit.Ignore;
public class HttpClientWagonTest extends TestCase {
- @Ignore("not sure how to test this")
public void testSetPreemptiveAuthParamViaConfig() {
HttpMethodConfiguration methodConfig = new HttpMethodConfiguration();
methodConfig.setUsePreemptive(true);
@@ -51,30 +49,8 @@ public void testSetPreemptiveAuthParamViaConfig() {
HttpParams params = method.getParams();
assertNotNull(params);
- // assertTrue( params.isParameterTrue( HttpClientParams.PREEMPTIVE_AUTHENTICATION ) );
}
- // @Ignore("not sure how to test this")
- // public void testSetMaxRedirectsParamViaConfig()
- // {
- // HttpMethodConfiguration methodConfig = new HttpMethodConfiguration();
- // int maxRedirects = 2;
- // methodConfig.addParam( HttpClientParams.MAX_REDIRECTS, "%i," + maxRedirects );
- //
- // HttpConfiguration config = new HttpConfiguration();
- // config.setAll( methodConfig );
- //
- // TestWagon wagon = new TestWagon();
- // wagon.setHttpConfiguration( config );
- //
- // HttpHead method = new HttpHead();
- // wagon.setParameters( method );
- //
- // HttpParams params = method.getParams();
- // assertNotNull( params );
- // assertEquals( maxRedirects, params.getIntParameter( HttpClientParams.MAX_REDIRECTS, -1 ) );
- // }
-
public void testDefaultHeadersUsedByDefault() {
HttpConfiguration config = new HttpConfiguration();
config.setAll(new HttpMethodConfiguration());
@@ -120,7 +96,6 @@ public void testTurnOffDefaultHeaders() {
assertNull(header);
}
- @Ignore("not sure how to test this")
public void testNTCredentialsWithUsernameNull() throws AuthenticationException, ConnectionException {
TestWagon wagon = new TestWagon();
@@ -131,12 +106,8 @@ public void testNTCredentialsWithUsernameNull() throws AuthenticationException,
assertNull(wagon.getAuthenticationInfo().getUserName());
assertNull(wagon.getAuthenticationInfo().getPassword());
-
- // assertFalse( wagon.getHttpClient()..getState().getCredentials( new AuthScope( null, 0 ) ) instanceof
- // NTCredentials );
}
- @Ignore("not sure how to test this")
public void testNTCredentialsNoNTDomain() throws AuthenticationException, ConnectionException {
TestWagon wagon = new TestWagon();
@@ -155,12 +126,8 @@ public void testNTCredentialsNoNTDomain() throws AuthenticationException, Connec
assertEquals(myUsernameNoNTDomain, wagon.getAuthenticationInfo().getUserName());
assertEquals(myPassword, wagon.getAuthenticationInfo().getPassword());
-
- // assertFalse( wagon.getClient().getState().getCredentials( new AuthScope( null, 0 ) ) instanceof NTCredentials
- // );
}
- @Ignore("not sure how to test this")
public void testNTCredentialsWithNTDomain() throws AuthenticationException, ConnectionException {
TestWagon wagon = new TestWagon();
@@ -181,14 +148,6 @@ public void testNTCredentialsWithNTDomain() throws AuthenticationException, Conn
assertEquals(myNTDomainAndUser, wagon.getAuthenticationInfo().getUserName());
assertEquals(myPassword, wagon.getAuthenticationInfo().getPassword());
-
- // Credentials credentials = wagon.getClient().getState().getCredentials( new AuthScope( null, 0 ) );
- // assertTrue( credentials instanceof NTCredentials );
- //
- // NTCredentials ntCredentials = (NTCredentials) credentials;
- // assertEquals( myNTDomain, ntCredentials.getDomain() );
- // assertEquals( myUsername, ntCredentials.getUserName() );
- // assertEquals( myPassword, ntCredentials.getPassword() );
}
private static final class TestWagon extends WebDavWagon {