You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by jh...@apache.org on 2014/07/03 10:05:16 UTC
git commit: [OPTIQ-303] Migrate issue URLs
Repository: incubator-optiq
Updated Branches:
refs/heads/master c34c14487 -> 899a62936
[OPTIQ-303] Migrate issue URLs
Also fix a few javadoc errors.
Project: http://git-wip-us.apache.org/repos/asf/incubator-optiq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-optiq/commit/899a6293
Tree: http://git-wip-us.apache.org/repos/asf/incubator-optiq/tree/899a6293
Diff: http://git-wip-us.apache.org/repos/asf/incubator-optiq/diff/899a6293
Branch: refs/heads/master
Commit: 899a62936d5f4fbde6d877e503d03929fdfc7ae0
Parents: c34c144
Author: Julian Hyde <ju...@gmail.com>
Authored: Thu Jul 3 00:18:24 2014 -0700
Committer: Julian Hyde <ju...@gmail.com>
Committed: Thu Jul 3 00:18:24 2014 -0700
----------------------------------------------------------------------
.../optiq/ImplementableAggFunction.java | 3 +-
.../optiq/rules/java/WinAggFrameContext.java | 7 +++--
.../java/org/eigenbase/sql/SqlOperator.java | 2 +-
.../optiq/test/JdbcFrontLinqBackTest.java | 4 ++-
.../net/hydromatic/optiq/test/JdbcTest.java | 31 ++++++++++++--------
.../optiq/test/ReflectiveSchemaTest.java | 4 +--
.../eigenbase/test/SqlToRelConverterTest.java | 13 ++++----
.../org/eigenbase/test/SqlValidatorTest.java | 2 +-
.../hydromatic/optiq/test/MongoAdapterTest.java | 9 +++---
9 files changed, 43 insertions(+), 32 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/main/java/net/hydromatic/optiq/ImplementableAggFunction.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/net/hydromatic/optiq/ImplementableAggFunction.java b/core/src/main/java/net/hydromatic/optiq/ImplementableAggFunction.java
index 6e87069..88a88fd 100644
--- a/core/src/main/java/net/hydromatic/optiq/ImplementableAggFunction.java
+++ b/core/src/main/java/net/hydromatic/optiq/ImplementableAggFunction.java
@@ -21,7 +21,7 @@ import net.hydromatic.optiq.rules.java.AggImplementor;
/**
* Function that can be translated to java code.
- * <p>
+ *
* @see net.hydromatic.optiq.rules.java.AggImplementor
* @see net.hydromatic.optiq.rules.java.WinAggImplementor
* @see net.hydromatic.optiq.rules.java.StrictAggImplementor
@@ -30,6 +30,7 @@ import net.hydromatic.optiq.rules.java.AggImplementor;
public interface ImplementableAggFunction extends AggregateFunction {
/**
* Returns implementor that translates the function to linq4j expression.
+ *
* @param windowContext true when aggregate is used in window context
* @return implementor that translates the function to linq4j expression.
*/
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/main/java/net/hydromatic/optiq/rules/java/WinAggFrameContext.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/net/hydromatic/optiq/rules/java/WinAggFrameContext.java b/core/src/main/java/net/hydromatic/optiq/rules/java/WinAggFrameContext.java
index c5db249..aee8ba5 100644
--- a/core/src/main/java/net/hydromatic/optiq/rules/java/WinAggFrameContext.java
+++ b/core/src/main/java/net/hydromatic/optiq/rules/java/WinAggFrameContext.java
@@ -21,8 +21,11 @@ import net.hydromatic.linq4j.expressions.Expression;
/**
* Provides information on the current window.
- * All the indexes are ready to be used in {@link WinAggFrameResultContext#arguments(net.hydromatic.linq4j.expressions.Expression)},
- * {@link WinAggFrameResultContext#rowTranslator(net.hydromatic.linq4j.expressions.Expression)} and similar methods.
+ *
+ * <p>All the indexes are ready to be used in
+ * {@link WinAggResultContext#arguments(net.hydromatic.linq4j.expressions.Expression)},
+ * {@link WinAggFrameResultContext#rowTranslator(net.hydromatic.linq4j.expressions.Expression)}
+ * and similar methods.
*/
public interface WinAggFrameContext {
/**
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/main/java/org/eigenbase/sql/SqlOperator.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/eigenbase/sql/SqlOperator.java b/core/src/main/java/org/eigenbase/sql/SqlOperator.java
index 7800cc1..13695c8 100644
--- a/core/src/main/java/org/eigenbase/sql/SqlOperator.java
+++ b/core/src/main/java/org/eigenbase/sql/SqlOperator.java
@@ -631,7 +631,7 @@ public abstract class SqlOperator {
* Returns whether this is a window function that requires ordering.
*
* <p>Per SQL:2011, 2, 6.10: "If <ntile function>, <lead or lag
- * function>, RANK or DENSE_RANK is specified, then the window ordering
+ * function>, RANK or DENSE_RANK is specified, then the window ordering
* clause shall be present."</p>
*
* @see #isAggregator()
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/test/java/net/hydromatic/optiq/test/JdbcFrontLinqBackTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/net/hydromatic/optiq/test/JdbcFrontLinqBackTest.java b/core/src/test/java/net/hydromatic/optiq/test/JdbcFrontLinqBackTest.java
index 3c2fdbd..4861420 100644
--- a/core/src/test/java/net/hydromatic/optiq/test/JdbcFrontLinqBackTest.java
+++ b/core/src/test/java/net/hydromatic/optiq/test/JdbcFrontLinqBackTest.java
@@ -193,7 +193,9 @@ public class JdbcFrontLinqBackTest {
.throws_("Column 'EMPID' not found in any table");
}
- /** Test case for https://github.com/julianhyde/optiq/issues/9. */
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-9">OPTIQ-9</a>,
+ * "RexToLixTranslator not incrementing local variable name counter". */
@Test public void testWhereOr() {
that()
.query(
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/test/java/net/hydromatic/optiq/test/JdbcTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/net/hydromatic/optiq/test/JdbcTest.java b/core/src/test/java/net/hydromatic/optiq/test/JdbcTest.java
index 2e9be1c..5f9d7b6 100644
--- a/core/src/test/java/net/hydromatic/optiq/test/JdbcTest.java
+++ b/core/src/test/java/net/hydromatic/optiq/test/JdbcTest.java
@@ -1344,7 +1344,7 @@ public class JdbcTest {
/** Tests 3-way AND.
*
- * <p>With <a href="https://github.com/julianhyde/optiq/issues/127">optiq-127,
+ * <p>With <a href="https://issues.apache.org/jira/browse/OPTIQ-127">OPTIQ-127,
* "EnumerableCalcRel can't support 3+ AND conditions"</a>, the last condition
* is ignored and rows with deptno=10 are wrongly returned.</p>
*/
@@ -1385,7 +1385,7 @@ public class JdbcTest {
}
/** Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/281">issue #281</a>,
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-281">OPTIQ-281</a>,
* "SQL type of EXTRACT is BIGINT but it is implemented as int". */
@Test public void testExtract() {
OptiqAssert.that()
@@ -1435,7 +1435,8 @@ public class JdbcTest {
}
/** Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/35">issue #35</a>. */
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-35">OPTIQ-35</a>,
+ * "Support parenthesized sub-clause in JOIN". */
@Ignore
@Test public void testJoinJoin() {
OptiqAssert.that()
@@ -1877,8 +1878,8 @@ public class JdbcTest {
* plan.
*
* <p>Test case for (not yet fixed)
- * <a href="https://github.com/julianhyde/optiq/issues/92">#92</a>, "Project
- * should be optimized away, not converted to EnumerableCalcRel".</p>
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-92">OPTIQ-92</a>,
+ * "Project should be optimized away, not converted to EnumerableCalcRel".</p>
*/
@Ignore
@Test public void testNoCalcBetweenJoins() throws IOException {
@@ -1968,7 +1969,7 @@ public class JdbcTest {
}
/** Test case for (not yet fixed)
- * <a href="https://github.com/julianhyde/optiq/issues/99">issue #99</a>,
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-99">OPTIQ-99</a>,
* "Recognize semi-join that has high selectivity and push it down". */
@Ignore
@Test public void testExplainJoin4() throws IOException {
@@ -2542,7 +2543,7 @@ public class JdbcTest {
}
/** Tests sorting by an expression not in the '*' select clause. Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/176">issue #176</a>. */
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-176">OPTIQ-176</a>. */
@Test public void testOrderStarByExpr() {
OptiqAssert.that().with(OptiqAssert.Config.REGULAR)
.query(
@@ -2727,7 +2728,9 @@ public class JdbcTest {
}
/** Limit implemented using {@link Queryable#take}. Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/96">issue #96</a>. */
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-96">OPTIQ-96</a>,
+ * "LIMIT against a table in a clone schema causes
+ * UnsupportedOperationException". */
@Test public void testLimitOnQueryableTable() {
OptiqAssert.that()
.with(OptiqAssert.Config.FOODMART_CLONE)
@@ -2740,7 +2743,8 @@ public class JdbcTest {
}
/** Limit implemented using {@link Queryable#take}. Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/70">issue #70</a>. */
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-70">OPTIQ-70</a>,
+ * "Joins seem to be very expensive in memory". */
@Test public void testSelfJoinCount() {
OptiqAssert.that()
.with(OptiqAssert.Config.JDBC_FOODMART)
@@ -3703,7 +3707,7 @@ public class JdbcTest {
/** Tests windowed aggregation with no ORDER BY clause.
*
* <p>Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/285">issue #285</a>,
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-285">OPTIQ-285</a>,
* "Window functions throw exception without ORDER BY".
*
* <p>Note:</p>
@@ -4333,8 +4337,9 @@ public class JdbcTest {
/** Tests a JSON model with a comment. Not standard JSON, but harmless to
* allow Jackson's comments extension.
*
- * <p>Test case for <a href="https://github.com/julianhyde/optiq/issues/160">
- * optiq-160, "Allow comments in schema definitions"</a>.</p> */
+ * <p>Test case for
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-160">OPTIQ-160</a>,
+ * "Allow comments in schema definitions".</p> */
@Test public void testModelWithComment() {
final String model =
FOODMART_MODEL.replace("schemas:", "/* comment */ schemas:");
@@ -5311,7 +5316,7 @@ public class JdbcTest {
"Cannot apply = to the two different charsets ISO-8859-1 and UTF-16LE");
// The CONVERT function (what SQL:2011 calls "character transliteration") is
- // not implemented yet. See https://github.com/julianhyde/optiq/issues/111.
+ // not implemented yet. See https://issues.apache.org/jira/browse/OPTIQ-111.
with.query(
"select * from \"employee\"\n"
+ "where convert(\"full_name\" using UTF16) = _UTF16'\u82f1\u56fd'")
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/test/java/net/hydromatic/optiq/test/ReflectiveSchemaTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/net/hydromatic/optiq/test/ReflectiveSchemaTest.java b/core/src/test/java/net/hydromatic/optiq/test/ReflectiveSchemaTest.java
index 907c4ce..aaea4a2 100644
--- a/core/src/test/java/net/hydromatic/optiq/test/ReflectiveSchemaTest.java
+++ b/core/src/test/java/net/hydromatic/optiq/test/ReflectiveSchemaTest.java
@@ -315,8 +315,8 @@ public class ReflectiveSchemaTest {
}
/** Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/119">optiq-119</a>.
- * Comparing a Java type with a SQL type. */
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-119">OPTIQ-119</a>,
+ * "Comparing a Java type long with a SQL type INTEGER gives wrong answer". */
@Test public void testCompareJavaAndSqlTypes() throws Exception {
final OptiqAssert.AssertThat with =
OptiqAssert.that().with("s", new CatchallSchema());
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/test/java/org/eigenbase/test/SqlToRelConverterTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/eigenbase/test/SqlToRelConverterTest.java b/core/src/test/java/org/eigenbase/test/SqlToRelConverterTest.java
index 03600c4..aae14db 100644
--- a/core/src/test/java/org/eigenbase/test/SqlToRelConverterTest.java
+++ b/core/src/test/java/org/eigenbase/test/SqlToRelConverterTest.java
@@ -87,8 +87,9 @@ public class SqlToRelConverterTest extends SqlToRelTestBase {
}
/**
- * Test case for <a href="https://github.com/julianhyde/optiq/issues/245">
- * Off-by-one translation of ON clause of JOIN</a>.
+ * Test case for
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-245">OPTIQ-245</a>,
+ * "Off-by-one translation of ON clause of JOIN".
*/
@Test public void testConditionOffByOne() {
// Bug causes the plan to contain
@@ -121,11 +122,9 @@ public class SqlToRelConverterTest extends SqlToRelTestBase {
check("SELECT * FROM emp JOIN dept USING (deptno)", "${plan}");
}
- /**
- * Test case for <a href="https://github.com/julianhyde/optiq/issues/74">
- * JOIN ... USING fails in 3-way join with
- * UnsupportedOperationException</a>.
- */
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-74">OPTIQ-74</a>,
+ * "JOIN ... USING fails in 3-way join with UnsupportedOperationException". */
@Test public void testJoinUsingThreeWay() {
check(
"select *\n"
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/core/src/test/java/org/eigenbase/test/SqlValidatorTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/eigenbase/test/SqlValidatorTest.java b/core/src/test/java/org/eigenbase/test/SqlValidatorTest.java
index 374553a..99cacef 100644
--- a/core/src/test/java/org/eigenbase/test/SqlValidatorTest.java
+++ b/core/src/test/java/org/eigenbase/test/SqlValidatorTest.java
@@ -6469,7 +6469,7 @@ public class SqlValidatorTest extends SqlValidatorTestCase {
}
/** Test case for
- * <a href="https://github.com/julianhyde/optiq/issues/145">optiq-145,
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-145">OPTIQ-145,
* "Unexpected upper-casing of keywords when using java lexer"</a>. */
@Test public void testLexJavaKeyword() {
final SqlTester tester1 = tester.withLex(Lex.JAVA);
http://git-wip-us.apache.org/repos/asf/incubator-optiq/blob/899a6293/mongodb/src/test/java/net/hydromatic/optiq/test/MongoAdapterTest.java
----------------------------------------------------------------------
diff --git a/mongodb/src/test/java/net/hydromatic/optiq/test/MongoAdapterTest.java b/mongodb/src/test/java/net/hydromatic/optiq/test/MongoAdapterTest.java
index 6264736..4c97474 100644
--- a/mongodb/src/test/java/net/hydromatic/optiq/test/MongoAdapterTest.java
+++ b/mongodb/src/test/java/net/hydromatic/optiq/test/MongoAdapterTest.java
@@ -343,7 +343,7 @@ public class MongoAdapterTest {
"warehouse_id=14; warehouse_state_province=CA",
"warehouse_id=24; warehouse_state_province=CA"))
.queryContains(
- // Per https://github.com/julianhyde/optiq/issues/164,
+ // Per https://issues.apache.org/jira/browse/OPTIQ-164,
// $match must occur before $project for good performance.
mongoChecker(
"{\n"
@@ -503,7 +503,7 @@ public class MongoAdapterTest {
+ "}"));
}
- @Ignore("https://github.com/julianhyde/optiq/issues/270")
+ @Ignore("https://issues.apache.org/jira/browse/OPTIQ-270")
@Test public void testGroupByHaving2() {
OptiqAssert.that()
.enable(enabled())
@@ -687,8 +687,9 @@ public class MongoAdapterTest {
}
}
- /** Test case for <a href="https://github.com/julianhyde/optiq/issues/286">
- * optiq-286, "Error casting MongoDB date"</a>. */
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/OPTIQ-286">OPTIQ-286</a>,
+ * "Error casting MongoDB date". */
@Test public void testDate() {
// Assumes that you have created the following collection before running
// this test: