You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/17 07:41:58 UTC
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #237: [MNG-7608] Adjust IT for default transport
cstamas opened a new pull request, #237:
URL: https://github.com/apache/maven-integration-testing/pull/237
If 3.9 uses native as default as well, there is no need anymore to distinguish between 3.9 and 4+.
---
https://issues.apache.org/jira/browse/MNG-7608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #237: [MNG-7608] Adjust IT for default transport
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #237:
URL: https://github.com/apache/maven-integration-testing/pull/237#discussion_r1071868777
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##########
@@ -105,14 +105,7 @@ private void performTest( /* nullable */ final String transport, final String lo
public void testResolverTransportDefault()
throws Exception
{
- if ( matchesVersionRange( "[4.0.0-alpha-3,)" ) )
- {
- performTest( null, NATIVE_LOG_SNIPPET );
- }
- else // [3.9.0,) but not 4, see above and ctor
- {
- performTest( null, WAGON_LOG_SNIPPET );
Review Comment:
No, as this class has 3 tests: default, forced-wagon, forced-native and is used in forced-wagon test. This change is only about default one (nothing forced).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas merged pull request #237: [MNG-7608] Adjust IT for default transport
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #237:
URL: https://github.com/apache/maven-integration-testing/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #237: [MNG-7608] Adjust IT for default transport
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #237:
URL: https://github.com/apache/maven-integration-testing/pull/237#discussion_r1071867128
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java:
##########
@@ -105,14 +105,7 @@ private void performTest( /* nullable */ final String transport, final String lo
public void testResolverTransportDefault()
throws Exception
{
- if ( matchesVersionRange( "[4.0.0-alpha-3,)" ) )
- {
- performTest( null, NATIVE_LOG_SNIPPET );
- }
- else // [3.9.0,) but not 4, see above and ctor
- {
- performTest( null, WAGON_LOG_SNIPPET );
Review Comment:
Can this snippet be deleted then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org