You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/27 16:30:37 UTC
[GitHub] [maven-release] slavino opened a new pull request, #133: SSH option preparation
slavino opened a new pull request, #133:
URL: https://github.com/apache/maven-release/pull/133
preparing SSH support
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] scott-avery commented on pull request #133: SSH option preparation
Posted by "scott-avery (via GitHub)" <gi...@apache.org>.
scott-avery commented on PR #133:
URL: https://github.com/apache/maven-release/pull/133#issuecomment-1581806809
any update for this? We encounter a problem that the registered ssh private key is not used by the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #133: SSH option preparation
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #133:
URL: https://github.com/apache/maven-release/pull/133#issuecomment-1140283492
JIRA is available to everyone: https://issues.apache.org/jira/projects/MRELEASE/issues/MRELEASE-1079?filter=allopenissues
This are a bit harde because it will required to setup SSHd with MINA and test that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] slavino commented on pull request #133: SSH option preparation
Posted by GitBox <gi...@apache.org>.
slavino commented on PR #133:
URL: https://github.com/apache/maven-release/pull/133#issuecomment-1140280142
I don't have access to your JIRA so feel free.
The contribution isn't any rocket science at this stage but shouldn't break anything (backward compatibility shouldn't be affected). If needed then feel free to delete these PRs and create a new one.
Before announcing it as new feature it will need to be covered by proper tests. Afterwards it can also be mentioned in the official plugin documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #133: SSH option preparation
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #133:
URL: https://github.com/apache/maven-release/pull/133#issuecomment-1139887681
I would recommend to collect all SSH private key related issues to one JIRA issue and create ONE PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org