[GitHub] [spark] HyukjinKwon commented on a change in pull request #30784: [SPARK-33560][BUILD] Add "unused-import" check to Maven compilation process

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #30784:
URL: https://github.com/apache/spark/pull/30784#discussion_r543803604



##########
File path: pom.xml
##########
@@ -3220,9 +3217,34 @@
 
     <profile>
       <id>scala-2.12</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
       <build>
         <pluginManagement>
           <plugins>
+            <plugin>
+              <groupId>net.alchim31.maven</groupId>
+              <artifactId>scala-maven-plugin</artifactId>
+              <version>4.4.0</version>
+              <configuration>
+                <args combine.children="append">
+                    <arg>-unchecked</arg>
+                    <arg>-Xfatal-warnings</arg>
+                    <arg>-deprecation</arg>
+                    <arg>-Ywarn-unused-import</arg>
+                    <arg>-P:silencer:globalFilters=.*deprecated.*</arg>

Review comment:
       Oh, actually I think it's matched with the Scala side actually: https://github.com/apache/spark/blob/master/project/SparkBuild.scala#L221-L226
   So I guess it might be fine because this is to make Maven work in the same way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org