[GitHub] [spark] kiszk commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

[GitBox <gi...@apache.org>]

kiszk commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693360852


   I also think that the proposed `getInt()` introduces the overhead.
   
   
   The access primitives such as `getInt()` does not usually require byte reverse if the method is used within an primitive unit (e.g. Integer). This is the usual usages in Spark. This is because Spark (and Java) uses machine-native endian within an primirive unit.
   
   IMHO, the usages of reverse order are the exceptional cases


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org