You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vsevolodstep-db (via GitHub)" <gi...@apache.org> on 2023/12/14 19:59:10 UTC
[PR] [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script [spark]
vsevolodstep-db opened a new pull request, #44360:
URL: https://github.com/apache/spark/pull/44360
### What changes were proposed in this pull request?
Currently, ClosureCleaner integration with SparkConnect is breaking Scala UDFs, as ClosureCleaner relies heavily on using reflection, which has some compatibility issues with Java 17. This PR adds a couple of options to Spark Connect Scala Client launch script to fix this issue.
### Why are the changes needed?
To make Spark Connect Scala Client work with Scala UDFs
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually run SparkConnect with java 17 and tested that I can run Scala UDF
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44360: [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script
URL: https://github.com/apache/spark/pull/44360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44360:
URL: https://github.com/apache/spark/pull/44360#issuecomment-1856512811
Mind rerunning https://github.com/vsevolodstep-db/spark/actions/runs/7210676936/job/19644434461?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44360:
URL: https://github.com/apache/spark/pull/44360#issuecomment-1858214123
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46409][CONNECT] Fix spark-connect-scala-client launch script [spark]
Posted by "vsevolodstep-db (via GitHub)" <gi...@apache.org>.
vsevolodstep-db commented on PR #44360:
URL: https://github.com/apache/spark/pull/44360#issuecomment-1858010619
@HyukjinKwon Re-ran failed jobs twice, they're still failing with a seemingly unrelated error...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org