[jira] [Commented] (HBASE-22758) Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896061#comment-16896061 ] 

Hudson commented on HBASE-22758:
--------------------------------

Results for branch master
	[build #1290 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1290/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-22758
>                 URL: https://issues.apache.org/jira/browse/HBASE-22758
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Priority: Major
>
> I saw the deleteFromMeta() method in DeleteTableProcedure & TruncateTableProcedure:
> {code}
> protected static void deleteFromMeta(final MasterProcedureEnv env,
>     final TableName tableName, List<RegionInfo> regions) throws IOException {
>   MetaTableAccessor.deleteRegions(env.getMasterServices().getConnection(), regions);
>   // Clean any remaining rows for this table.
>   cleanAnyRemainingRows(env, tableName);
>   // clean region references from the server manager
>   env.getMasterServices().getServerManager().removeRegions(regions);
>   // Clear Favored Nodes for this table
>   FavoredNodesManager fnm = env.getMasterServices().getFavoredNodesManager();
>   if (fnm != null) {
>     fnm.deleteFavoredNodesForRegions(regions);
>   }
> }
> {code}
> 1. deleteRegions : delete the info column family first;
> 2. cleanAnyRemainingRows : delete the whole row for regions then.
> In fact, we can only change to delete the whole row, no need the extra info cf deletion any more.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)