You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/26 16:52:40 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #9916: Rename build/ to m4/
JosiahWI opened a new pull request, #9916:
URL: https://github.com/apache/trafficserver/pull/9916
This fixes an issue on case-insensitive filesystems where the BUILD item in .gitignore causes the build/ directory to be ignored in git. It also opens up build/ for use as an out of source build directory, which is a very common idiom for CMake users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1243866294
##########
m4/tcmalloc.m4:
##########
@@ -0,0 +1,56 @@
+dnl -------------------------------------------------------- -*- autoconf -*-
Review Comment:
Why was this file added? There was a PR to remove tcmalloc from the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1246011679
##########
ci/rat-regex.txt:
##########
@@ -1,6 +1,6 @@
^BUILDS$
^autom4te\.cache$
-^build$
+^m4$
Review Comment:
RAT checks our CMake scripts. This seems like an analogous case for automake. Just my two cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1246025934
##########
ci/rat-regex.txt:
##########
@@ -1,6 +1,6 @@
^BUILDS$
^autom4te\.cache$
-^build$
+^m4$
Review Comment:
Probably good to check them. Let's do that as a separate PR though in case something goes wrong or we change our mind so it would be easy to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #9916: Rename build/ to m4/
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1612747609
@JosiahWI Can you also remove "BUILD" from the gitignore? It looks like @zwoop added it in https://github.com/apache/trafficserver/pull/8428, but it looks accidental to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] moonchen commented on pull request #9916: Rename build/ to m4/
Posted by "moonchen (via GitHub)" <gi...@apache.org>.
moonchen commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1608384675
Please also update README.md to reflect the change in directory structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1611517903
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1612354671
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1612160604
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1609328990
Rebased on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1244329678
##########
example/plugins/c-api/Makefile.am:
##########
@@ -14,8 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-include $(top_srcdir)/build/plugins.mk
-include $(top_srcdir)/build/tidy.mk
+include $(top_srcdir)/m4/plugins.mk
+include $(top_srcdir)/m4/tidy.mk
Review Comment:
Should we put the makefile includes in `$(top_srcdir)/mk`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1242486570
##########
.gitignore:
##########
@@ -37,12 +37,12 @@ Makefile.in
/tags
/_build
-build/_aux/
-build/libtool.m4
-build/ltoptions.m4
-build/ltsugar.m4
-build/ltversion.m4
-build/lt~obsolete.m4
+m4/_aux/
+m4/libtool.m4
+m4/ltoptions.m4
+m4/ltsugar.m4
+m4/ltversion.m4
+m4/lt~obsolete.m4
BUILD
Review Comment:
Too slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1613869730
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1245536968
##########
README.md:
##########
@@ -45,6 +44,7 @@ trafficserver ............. Top src dir
├── lib ...................
│ ├── records ........... Library for config files
│ └── yamlcpp ........... Library for YAML of C++
+├── m4 .................... Custom macros for configure.ac
Review Comment:
mk directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1245984148
##########
ci/rat-regex.txt:
##########
@@ -1,6 +1,6 @@
^BUILDS$
^autom4te\.cache$
-^build$
+^m4$
Review Comment:
Do we want rat to check our m4 files? I wonder if this line should just be removed? @bneradt do you have any input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1613149928
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1245119598
##########
example/plugins/c-api/Makefile.am:
##########
@@ -14,8 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-include $(top_srcdir)/build/plugins.mk
-include $(top_srcdir)/build/tidy.mk
+include $(top_srcdir)/m4/plugins.mk
+include $(top_srcdir)/m4/tidy.mk
Review Comment:
Great suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1242485997
##########
.gitignore:
##########
@@ -37,12 +37,12 @@ Makefile.in
/tags
/_build
-build/_aux/
-build/libtool.m4
-build/ltoptions.m4
-build/ltsugar.m4
-build/ltversion.m4
-build/lt~obsolete.m4
+m4/_aux/
+m4/libtool.m4
+m4/ltoptions.m4
+m4/ltsugar.m4
+m4/ltversion.m4
+m4/lt~obsolete.m4
BUILD
Review Comment:
Let's add `build` (lowercase) to the .gitignore as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#discussion_r1243867383
##########
m4/tcmalloc.m4:
##########
@@ -0,0 +1,56 @@
+dnl -------------------------------------------------------- -*- autoconf -*-
Review Comment:
Mistake during rebase. Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1611512558
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9916: Rename build/ to m4/
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1611600677
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on pull request #9916: Rename build/ to m4/
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9916:
URL: https://github.com/apache/trafficserver/pull/9916#issuecomment-1613672288
[approve ci ubuntu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org