You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2010/06/29 21:20:51 UTC
[jira] Created: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
-------------------------------------------------------------------------------
Key: DROIDS-91
URL: https://issues.apache.org/jira/browse/DROIDS-91
Project: Droids
Issue Type: Bug
Components: core
Affects Versions: 0.0.1
Reporter: Eugen Paraschiv
Fix For: 0.0.1
There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
- getLastModifedDate
- setLastModifedDate
- getLastModifiedDate
This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv resolved DROIDS-91.
-----------------------------------
Resolution: Fixed
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91_v2.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-91:
----------------------------------
Attachment: DROIDS-91_v2.patch
Sorry for the formatting mixup, I adjusted my Eclipse formatter to match the droids code conventions.
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91_v2.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-91:
----------------------------------
Attachment: DROIDS-91.patch
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898559#action_12898559 ]
Javier Puerto commented on DROIDS-91:
-------------------------------------
I was trying to apply the patch but it seems to add formating changes. Please review the patch following the project guidelines.
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-91:
----------------------------------
Attachment: (was: DROIDS-91.patch)
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91_v2.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-91) Rename misspelled getLastModifedDate
and setLastModifedDate methods in LinkTask
Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898565#action_12898565 ]
Javier Puerto commented on DROIDS-91:
-------------------------------------
I have the same problems.
The current patch:
--- src/main/java/org/apache/droids/LinkTask.java (revision 985452)
+++ src/main/java/org/apache/droids/LinkTask.java (working copy)
@@ -23,31 +23,28 @@
import org.apache.droids.api.Link;
-public class LinkTask implements Link, Serializable
-{
+public class LinkTask implements Link, Serializable {
The path should be relative a $DROIDS_HOME. In this case the file is in droids-core but I had to check it. The change in the class declaration don't add any functionality and is only code formating so it should be out.
I'm going to patch it but review for further contributions. Thanks.
Commited revision: r985463
> Rename misspelled getLastModifedDate and setLastModifedDate methods in LinkTask
> -------------------------------------------------------------------------------
>
> Key: DROIDS-91
> URL: https://issues.apache.org/jira/browse/DROIDS-91
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-91_v2.patch
>
>
> There are 3 getter/setter in LinkTask that deal with the same field; two of them are misspelled:
> - getLastModifedDate
> - setLastModifedDate
> - getLastModifiedDate
> This should be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.