You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Max Lapan (JIRA)" <ji...@apache.org> on 2012/08/02 11:21:03 UTC
[jira] [Created] (HBASE-6499) StoreScanner's QueryMatcher not reset
on store update
Max Lapan created HBASE-6499:
--------------------------------
Summary: StoreScanner's QueryMatcher not reset on store update
Key: HBASE-6499
URL: https://issues.apache.org/jira/browse/HBASE-6499
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.96.0
Reporter: Max Lapan
Assignee: Max Lapan
When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not
reset on store update
Posted by "Max Lapan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484835#comment-13484835 ]
Max Lapan commented on HBASE-6499:
----------------------------------
Yes, this bug related with HBASE-6900, but also fixes seek() case.
> StoreScanner's QueryMatcher not reset on store update
> -----------------------------------------------------
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: Max Lapan
> Assignee: Max Lapan
> Attachments: StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6499) StoreScanner's QueryMatcher not reset
on store update
Posted by "Max Lapan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Lapan updated HBASE-6499:
-----------------------------
Status: Patch Available (was: Open)
> StoreScanner's QueryMatcher not reset on store update
> -----------------------------------------------------
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: Max Lapan
> Assignee: Max Lapan
> Attachments: StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6499) StoreScanner's QueryMatcher not reset
on store update
Posted by "Max Lapan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Lapan updated HBASE-6499:
-----------------------------
Attachment: StoreScanner_not_reset_matcher.patch
> StoreScanner's QueryMatcher not reset on store update
> -----------------------------------------------------
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: Max Lapan
> Assignee: Max Lapan
> Attachments: StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not
reset on store update
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427241#comment-13427241 ]
Hadoop QA commented on HBASE-6499:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538885/StoreScanner_not_reset_matcher.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//console
This message is automatically generated.
> StoreScanner's QueryMatcher not reset on store update
> -----------------------------------------------------
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: Max Lapan
> Assignee: Max Lapan
> Attachments: StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not
reset on store update
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484829#comment-13484829 ]
Anoop Sam John commented on HBASE-6499:
---------------------------------------
@Max
Is this issue same as HBASE-6900 which is fixed already in 0.94 and Trunk. Pls see once.
> StoreScanner's QueryMatcher not reset on store update
> -----------------------------------------------------
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: Max Lapan
> Assignee: Max Lapan
> Attachments: StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy current KeyValueHeap and recreate it using checkReseek call. Besides heap recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by next(). If someone calls seek() just after store changed, it gets wrong scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible in future. Personally, I spent lots of time to find source of wrong scanner results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira