You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/04 19:55:42 UTC

[GitHub] [maven] MartinKanters edited a comment on issue #287: [MNG-6065] - Log fail-level option.

MartinKanters edited a comment on issue #287: [MNG-6065] - Log fail-level option.
URL: https://github.com/apache/maven/pull/287#issuecomment-561813067
 
 
   Good point about the two loggers, I didn't think about the possible performance degradations.
   ---
   
   And nice to hear that we can make use of Java 8 now :) I've applied it where I saw fit.
   ---
   
   About severity vs level. I think level is the correct name, as we map it directly into the Enum `org.slf4j.event.Level`.
   ---
   
   With the latest changes, I've moved more of the threshold recording logic into the `LogLevelRecorder` class instead of the LoggerFactory. What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services